Re: [PATCH] builtin/commit.c: prevent bad commits

2018-04-01 Thread Jeff King
On Sun, Apr 01, 2018 at 05:06:50PM +0300, Dan Aloni wrote: > These commits which have hashes starting with the hex string 'bad', > always give me the chills. Why should a perfectly good commit be > jinxed? > > Statistically, one of 4096 commits may be 'bad'. This change adds a > '--prevent-bad' s

Re: [PATCH] builtin/commit.c: prevent bad commits

2018-04-01 Thread Junio C Hamano
Dan Aloni writes: > These commits which have hashes starting with the hex string 'bad', > always give me the chills. Why should a perfectly good commit be > jinxed? > ... > Note that this change does not affect actual software quality maintained > using Git. Thus, it is recommended keep testing a

[PATCH] builtin/commit.c: prevent bad commits

2018-04-01 Thread Dan Aloni
These commits which have hashes starting with the hex string 'bad', always give me the chills. Why should a perfectly good commit be jinxed? Statistically, one of 4096 commits may be 'bad'. This change adds a '--prevent-bad' switch to the commit command in order to prevent such commit hashes from