Re: [PATCH] builtin/commit.c: fix type warnings from gcc and sparse

2014-08-29 Thread Junio C Hamano
Jeff King writes: > On Fri, Aug 29, 2014 at 05:36:21PM +0100, Ramsay Jones wrote: > >> On 32-bit platforms (only), gcc and sparse both issue warnings >> about the type of the pointer expression passed as the third >> argument to find_commit_header(). In order to suppress the >> warnings, we simp

Re: [PATCH] builtin/commit.c: fix type warnings from gcc and sparse

2014-08-29 Thread Jeff King
On Fri, Aug 29, 2014 at 05:36:21PM +0100, Ramsay Jones wrote: > On 32-bit platforms (only), gcc and sparse both issue warnings > about the type of the pointer expression passed as the third > argument to find_commit_header(). In order to suppress the > warnings, we simply change the type of the '

[PATCH] builtin/commit.c: fix type warnings from gcc and sparse

2014-08-29 Thread Ramsay Jones
On 32-bit platforms (only), gcc and sparse both issue warnings about the type of the pointer expression passed as the third argument to find_commit_header(). In order to suppress the warnings, we simply change the type of the 'len' variable to size_t. Signed-off-by: Ramsay Jones --- Hi Jeff,