George Papanikolaou writes:
> On Tue, Mar 25, 2014 at 6:54 AM, Junio C Hamano wrote:
>> As a tangent, I have a suspicion that the current implementation may
>> be wrong at the beginning of the string. Wouldn't it match " abc"
>> and "abc", even though these two strings shouldn't match?
>
> Woul
On Tue, Mar 25, 2014 at 6:54 AM, Junio C Hamano wrote:
> As a tangent, I have a suspicion that the current implementation may
> be wrong at the beginning of the string. Wouldn't it match " abc"
> and "abc", even though these two strings shouldn't match?
Wouldn't that be accomplished by just remo
Michael Haggerty writes:
>> -while ((*last1 == '\r') || (*last1 == '\n'))
>> +while (iswspace(*last1))
>> last1--;
>> -while ((*last2 == '\r') || (*last2 == '\n'))
>> +while (iswspace(*last2))
>> last2--;
>>
>> /* skip leading whitespace */
>>
>
>
On Sat, Mar 22, 2014 at 5:33 AM, George Papanikolaou
wrote:
> On Sat, Mar 22, 2014 at 12:46 AM, Eric Sunshine
> wrote:
>> Because it's unnecessary and invites confusion from people reading the
>> code since they now have to wonder if there is something unusual and
>> non-obvious going. Worse, th
On Sat, Mar 22, 2014 at 12:46 AM, Eric Sunshine wrote:
>
> Because it's unnecessary and invites confusion from people reading the
> code since they now have to wonder if there is something unusual and
> non-obvious going. Worse, the two loops immediately below the ones you
> changed, as well as th
[Please reply on-list to review comments. Other people may learn from
the discussion or have comments of their own.]
On Fri, Mar 21, 2014 at 6:00 PM, George Papanikolaou
wrote:
> On Fri, Mar 21, 2014 at 4:48 AM, Eric Sunshine
> wrote:
>>
>> Did you verify that it is safe to strip all whitespace
On 03/20/2014 08:39 PM, George Papanikolaou wrote:
> Removing the bloat of checking for both '\r' and '\n' with the prettier
> iswspace() function which checks for other characters as well. (read: \f \t
> \v)
> ---
>
> This is one more try to clean up this fuzzy_matchlines() function as part of a
On Thu, Mar 20, 2014 at 3:39 PM, George Papanikolaou
wrote:
> Removing the bloat of checking for both '\r' and '\n' with the prettier
> iswspace() function which checks for other characters as well. (read: \f \t
> \v)
Use imperative mood. "Remove" rather than "Removing".
Bloat? Prettier? Subjec
Removing the bloat of checking for both '\r' and '\n' with the prettier
iswspace() function which checks for other characters as well. (read: \f \t \v)
---
This is one more try to clean up this fuzzy_matchlines() function as part of a
microproject for GSOC. The rest more clarrified microprojects w
9 matches
Mail list logo