Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-16 Thread Johannes Schindelin
Hi Emily, On Thu, 15 Aug 2019, Emily Shaffer wrote: > On Thu, Aug 15, 2019 at 10:07:57PM +0200, Johannes Schindelin wrote: > > > > On Thu, 15 Aug 2019, Derrick Stolee wrote: > > > > > On 8/14/2019 10:34 PM, Emily Shaffer wrote: > > > > diff --git a/git-bugreport.sh b/git-bugreport.sh > > > > new

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-16 Thread Emily Shaffer
On Fri, Aug 16, 2019 at 09:41:41AM -0700, Junio C Hamano wrote: > Emily Shaffer writes: > > > I think comparing this habit to the .gitignore isn't quite fair - > > .gitignore tells me I forgot to add my new command binary to it, when I > > run `git status` to see what I need to add to my commit w

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-16 Thread Junio C Hamano
Emily Shaffer writes: > I think comparing this habit to the .gitignore isn't quite fair - > .gitignore tells me I forgot to add my new command binary to it, when I > run `git status` to see what I need to add to my commit with new > command. That is why I said that we need to actively work on, i

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Emily Shaffer
On Thu, Aug 15, 2019 at 04:40:50PM -0700, Junio C Hamano wrote: > Emily Shaffer writes: > > > I think a whitelist of config options to print would grow stale > > immediately, and the options we're missing would be very likely to be > > configs to turn on new experimental features - which is proba

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Junio C Hamano
Emily Shaffer writes: > I think a whitelist of config options to print would grow stale > immediately, and the options we're missing would be very likely to be > configs to turn on new experimental features - which is probably what we > most want the bugreport for. The implementation of your "gi

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Emily Shaffer
On Thu, Aug 15, 2019 at 03:29:24PM -0700, Junio C Hamano wrote: > Emily Shaffer writes: > > >> > +NOTE > >> > + > >> > +Bug reports can be sent to git@vger.kernel.org. > >> > >> I am not sure if this belongs here. > > > > Sure, I wasn't certain either. Would you rather I remove the "what to

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Emily Shaffer
On Thu, Aug 15, 2019 at 07:36:57AM -0700, Junio C Hamano wrote: > Derrick Stolee writes: > > > Config options to consider stripping out: > > > > *url* > > *pass* (anything "password" but also "sendmail.smtppass") > > Blacklisting? I wonder if users feel safer if these are limited to > k

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Junio C Hamano
Emily Shaffer writes: >> > +NOTE >> > + >> > +Bug reports can be sent to git@vger.kernel.org. >> >> I am not sure if this belongs here. > > Sure, I wasn't certain either. Would you rather I remove the "what to do > with this bugreport" NOTE section entirely? Not really. You are invoking an

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Emily Shaffer
On Thu, Aug 15, 2019 at 10:07:57PM +0200, Johannes Schindelin wrote: > Hi, > > On Thu, 15 Aug 2019, Derrick Stolee wrote: > > > On 8/14/2019 10:34 PM, Emily Shaffer wrote: > > > diff --git a/git-bugreport.sh b/git-bugreport.sh > > > new file mode 100755 > > > index 00..2200703a51 > > > --

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Emily Shaffer
On Thu, Aug 15, 2019 at 11:10:12AM -0700, Junio C Hamano wrote: > Emily Shaffer writes: > > > diff --git a/Documentation/git-bugreport.txt > > b/Documentation/git-bugreport.txt > > new file mode 100644 > > index 00..c5f45bbee8 > > --- /dev/null > > +++ b/Documentation/git-bugreport.txt >

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Emily Shaffer
On Thu, Aug 15, 2019 at 10:15:24AM -0400, Derrick Stolee wrote: > > - Do we want to advertise the Git mailing list for bug reports? > > That is possible. Isn't there another mailing list for git users? I know there's an IRC channel for Git users, I dunno about mailing list. I'm worried that pla

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Johannes Schindelin
Hi, On Thu, 15 Aug 2019, Derrick Stolee wrote: > On 8/14/2019 10:34 PM, Emily Shaffer wrote: > > diff --git a/git-bugreport.sh b/git-bugreport.sh > > new file mode 100755 > > index 00..2200703a51 > > --- /dev/null > > +++ b/git-bugreport.sh > > At first I was alarmed by "What? another she

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Junio C Hamano
Emily Shaffer writes: > diff --git a/Documentation/git-bugreport.txt b/Documentation/git-bugreport.txt > new file mode 100644 > index 00..c5f45bbee8 > --- /dev/null > +++ b/Documentation/git-bugreport.txt > @@ -0,0 +1,48 @@ > +git-bugreport(1) > + > + > +NAME > + > +gi

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Junio C Hamano
Derrick Stolee writes: > Config options to consider stripping out: > > *url* > *pass* (anything "password" but also "sendmail.smtppass") Blacklisting? I wonder if users feel safer if these are limited to known-benign ones. >> +echo "[Configured Hooks]" >> +find "$GIT_DIR/ho

Re: [PATCH] bugreport: add tool to generate debugging info

2019-08-15 Thread Derrick Stolee
On 8/14/2019 10:34 PM, Emily Shaffer wrote: > Make it easier for users who encounter a bug to send a report by > collecting some state information, intended to be viewed by humans > familiar with Git. This is an excellent idea! VFS for Git has a similar "diagnose" command that collects logs, confi

[PATCH] bugreport: add tool to generate debugging info

2019-08-14 Thread Emily Shaffer
Make it easier for users who encounter a bug to send a report by collecting some state information, intended to be viewed by humans familiar with Git. Teach Git how to prompt the user for a good bug report: reproduction steps, expected behavior, and actual behavior. Also, teach Git to write down i