Re: [PATCH] branch: use $curr_branch_short more

2013-09-15 Thread Felipe Contreras
On Sun, Sep 15, 2013 at 6:42 AM, René Scharfe wrote: > Am 09.09.2013 01:13, schrieb Felipe Contreras: > >> On Sun, Sep 8, 2013 at 10:21 AM, René Scharfe wrote: >>> >>> Am 31.08.2013 19:20, schrieb Felipe Contreras: >>> A summary should contain as much information that would allow me to

Re: [PATCH] branch: use $curr_branch_short more

2013-09-15 Thread René Scharfe
Am 09.09.2013 01:13, schrieb Felipe Contreras: On Sun, Sep 8, 2013 at 10:21 AM, René Scharfe wrote: Am 31.08.2013 19:20, schrieb Felipe Contreras: A summary should contain as much information that would allow me to skip the commit message as possible. If I can't tell from the summary if I ca

Re: [PATCH] branch: use $curr_branch_short more

2013-09-08 Thread Felipe Contreras
On Sun, Sep 8, 2013 at 10:21 AM, René Scharfe wrote: > Am 31.08.2013 19:20, schrieb Felipe Contreras: > >> A summary should contain as much information that would allow me to >> skip the commit message as possible. >> >> If I can't tell from the summary if I can safely skip the commit >> message,

Re: [PATCH] branch: use $curr_branch_short more

2013-09-08 Thread René Scharfe
Am 31.08.2013 19:20, schrieb Felipe Contreras: A summary should contain as much information that would allow me to skip the commit message as possible. If I can't tell from the summary if I can safely skip the commit message, the summary is not doing a good job. "trivial simplification" explain

Re: [PATCH] branch: use $curr_branch_short more

2013-09-03 Thread Junio C Hamano
Felipe Contreras writes: >> Subject: branch: use $curr_branch_short more > > Why? I don't think that summary explains the reason for being for this > patch, also, it starts with branch: instead of pull: > > Subject: pull: trivial simplification > > With that summary, people would have an easier t

Re: [PATCH] branch: use $curr_branch_short more

2013-08-31 Thread Felipe Contreras
On Sat, Aug 31, 2013 at 5:28 AM, René Scharfe wrote: > Am 31.08.2013 11:22, schrieb Felipe Contreras: > >> On Sat, Aug 31, 2013 at 4:11 AM, René Scharfe wrote: >> Subject: pull: trivial simplification With that summary, people would have an easier time figuring out if they nee

Re: [PATCH] branch: use $curr_branch_short more

2013-08-31 Thread René Scharfe
Am 31.08.2013 11:22, schrieb Felipe Contreras: On Sat, Aug 31, 2013 at 4:11 AM, René Scharfe wrote: Subject: pull: trivial simplification With that summary, people would have an easier time figuring out if they need to read more about the patch or not. "trivial simplification" is too gener

Re: [PATCH] branch: use $curr_branch_short more

2013-08-31 Thread Felipe Contreras
On Sat, Aug 31, 2013 at 4:11 AM, René Scharfe wrote: >> Subject: pull: trivial simplification >> >> With that summary, people would have an easier time figuring out if >> they need to read more about the patch or not. > > > "trivial simplification" is too generic; we could have lots of them. No,

Re: [PATCH] branch: use $curr_branch_short more

2013-08-31 Thread René Scharfe
Am 31.08.2013 10:22, schrieb Felipe Contreras: Subject: branch: use $curr_branch_short more Why? I don't think that summary explains the reason for being for this patch, also, it starts with branch: instead of pull: You're right about "branch" vs. "pull". I'll better go back to bed. ~_~ Su

Re: [PATCH] branch: use $curr_branch_short more

2013-08-31 Thread Felipe Contreras
> Subject: branch: use $curr_branch_short more Why? I don't think that summary explains the reason for being for this patch, also, it starts with branch: instead of pull: Subject: pull: trivial simplification With that summary, people would have an easier time figuring out if they need to read m

[PATCH] branch: use $curr_branch_short more

2013-08-31 Thread René Scharfe
One of the first things git-pull.sh does is setting $curr_branch to the target of HEAD and $curr_branch_short to the same but with the leading "refs/heads/" removed. Use $curr_branch_short in the function error_on_no_merge_candidates instead of removing the prefix from $curr_branch directly. The