Re: [PATCH] branch: update all per-worktree HEADs when renaming a branch

2016-03-25 Thread Kazuki Yamaguchi
On Tue, Mar 22, 2016 at 07:49:00AM +0700, Duy Nguyen wrote: > On Tue, Mar 22, 2016 at 12:41 AM, Eric Sunshine > wrote: > >> diff --git a/worktree.c b/worktree.c > >> @@ -217,3 +217,41 @@ char *find_shared_symref(const char *symref, const > >> char *target) > >> +int update_worktrees_head_symref(

Re: [PATCH] branch: update all per-worktree HEADs when renaming a branch

2016-03-25 Thread Kazuki Yamaguchi
Hello, On 03/22/2016 03:41 AM, Eric Sunshine wrote: >> diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh >> @@ -126,7 +126,19 @@ test_expect_success 'git branch -M foo bar should fail >> when bar is checked out' >> test_expect_success 'git branch -M baz bam should succeed when baz is >> check

Re: [PATCH] branch: update all per-worktree HEADs when renaming a branch

2016-03-21 Thread Duy Nguyen
On Tue, Mar 22, 2016 at 12:41 AM, Eric Sunshine wrote: >> diff --git a/worktree.c b/worktree.c >> @@ -217,3 +217,41 @@ char *find_shared_symref(const char *symref, const char >> *target) >> +int update_worktrees_head_symref(const char *oldref, const char *newref) >> +{ >> + int error = 0; >

Re: [PATCH] branch: update all per-worktree HEADs when renaming a branch

2016-03-21 Thread Eric Sunshine
On Mon, Mar 21, 2016 at 5:50 AM, Kazuki Yamaguchi wrote: > When renaming a branch, the current code only updates the current > working tree's HEAD, but it should update .git/HEAD of all checked out > working trees. > > This is the current behavior, /path/to/wt's HEAD is not updated: > [...] > This

[PATCH] branch: update all per-worktree HEADs when renaming a branch

2016-03-21 Thread Kazuki Yamaguchi
When renaming a branch, the current code only updates the current working tree's HEAD, but it should update .git/HEAD of all checked out working trees. This is the current behavior, /path/to/wt's HEAD is not updated: % git worktree list /path/to 2c3c5f2 [master] /path/to/wt 2c3c5f2 [ol