Re: [PATCH] branch: handle errors on setting tracking branches

2015-09-25 Thread Junio C Hamano
Jeff King writes: > I count 4 callers in the current code, and none of them currently looks > at the return value. Your patch updates setup_tracking() to propagate > the error, which is good. But that is called from exactly one place, > create_branch(), which also ignores the outcome. :-/ > > I d

Re: [PATCH] branch: handle errors on setting tracking branches

2015-09-24 Thread Jeff King
On Thu, Sep 24, 2015 at 12:32:01PM +0200, Patrick Steinhardt wrote: > The function `install_branch_config`, which is used to set up > tracking branches, does not verify return codes of > `git_config_set`. Due to this we may incorrectly print that a > tracking branch has been set up when in fact we

[PATCH] branch: handle errors on setting tracking branches

2015-09-24 Thread Patrick Steinhardt
The function `install_branch_config`, which is used to set up tracking branches, does not verify return codes of `git_config_set`. Due to this we may incorrectly print that a tracking branch has been set up when in fact we did not due to an error. Fix this by checking the return value of `git_conf