[PATCH] branch, commit, name-rev: ease up boolean conditions

2013-08-06 Thread Stefan Beller
Now that the variables are set by OPT_BOOL, which makes sure to have the values being 0 or 1 after parsing, we do not need the double negation to map any other value to 1 for integer variables. Signed-off-by: Stefan Beller --- builtin/branch.c | 3 ++- builtin/commit.c | 2 +- builtin/name-r

Re: [PATCH] branch, commit, name-rev: ease up boolean conditions

2013-08-06 Thread Stefan Beller
On 08/06/2013 08:46 PM, Eric Sunshine wrote: > On Tue, Aug 6, 2013 at 9:07 AM, Stefan Beller > wrote: >> Now that the variables are readin by OPT_BOOL, which makes sure > > Do you mean s/readin/read in/ ? > > Or should it be s/readin/set/ ? > >> to have the values being 0 or 1 after reading, we

Re: [PATCH] branch, commit, name-rev: ease up boolean conditions

2013-08-06 Thread Eric Sunshine
On Tue, Aug 6, 2013 at 9:07 AM, Stefan Beller wrote: > Now that the variables are readin by OPT_BOOL, which makes sure Do you mean s/readin/read in/ ? Or should it be s/readin/set/ ? > to have the values being 0 or 1 after reading, we do not need > the double negation to map any other value to

[PATCH] branch, commit, name-rev: ease up boolean conditions

2013-08-06 Thread Stefan Beller
Now that the variables are readin by OPT_BOOL, which makes sure to have the values being 0 or 1 after reading, we do not need the double negation to map any other value to 1 for integer variables. Signed-off-by: Stefan Beller --- builtin/branch.c | 3 ++- builtin/commit.c | 2 +- builtin/nam