Re: [PATCH] blame: move blame_entry duplication to add_blame_entry()

2017-03-10 Thread René Scharfe
Am 10.03.2017 um 09:32 schrieb Jeff King: On Fri, Mar 10, 2017 at 01:12:59AM +0100, René Scharfe wrote: All callers of add_blame_entry() allocate and copy the second argument. Let the function do it for them, reducing code duplication. I assume you found this due to the DUPLICATE() discussion

Re: [PATCH] blame: move blame_entry duplication to add_blame_entry()

2017-03-10 Thread Jeff King
On Fri, Mar 10, 2017 at 01:12:59AM +0100, René Scharfe wrote: > All callers of add_blame_entry() allocate and copy the second argument. > Let the function do it for them, reducing code duplication. I assume you found this due to the DUPLICATE() discussion elsewhere. Regardless of the results of t

[PATCH] blame: move blame_entry duplication to add_blame_entry()

2017-03-09 Thread René Scharfe
All callers of add_blame_entry() allocate and copy the second argument. Let the function do it for them, reducing code duplication. Signed-off-by: Rene Scharfe --- builtin/blame.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/builtin/blame.c b/bui