Re: [PATCH] blame: add color

2013-10-08 Thread Chris J Arges
On 10/08/2013 10:16 AM, Junio C Hamano wrote: > Chris J Arges writes: > >> Add colorized text for git blame when color.interactive is enabled. > > It does not make any sense to tie this to color.interactive at all, > at least to me. The "check color.blame and if absent fall back to > color.ui",

Re: [PATCH] blame: add color

2013-10-08 Thread Junio C Hamano
Chris J Arges writes: > Add colorized text for git blame when color.interactive is enabled. It does not make any sense to tie this to color.interactive at all, at least to me. The "check color.blame and if absent fall back to color.ui", which is the usual pattern, would be more appropriate. >

Re: [PATCH] blame: add color

2013-10-08 Thread Stefan Beller
On 10/08/2013 04:18 PM, Chris J Arges wrote: > Add colorized text for git blame when color.interactive is enabled. > This work is based on the colorization code in builtin/clean.c. > Another way to color blame, would be by commit, not by row. Try "git gui blame ", to see what I mean. The colorisa

[PATCH] blame: add color

2013-10-08 Thread Chris J Arges
Add colorized text for git blame when color.interactive is enabled. This work is based on the colorization code in builtin/clean.c. Signed-off-by: Chris J Arges --- builtin/blame.c | 51 +-- 1 file changed, 49 insertions(+), 2 deletions(-) diff