Re: [PATCH] attr: mark a file-local symbol as static

2017-01-18 Thread Ramsay Jones
On 18/01/17 23:05, Brandon Williams wrote: > On 01/18, Ramsay Jones wrote: >> >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Brandon, >> >> If you need to re-roll your 'bw/attr' branch, could you please >> squash this into the relevant patch (commit 8908457159, >> "attr: use hashmap for attribut

Re: [PATCH] attr: mark a file-local symbol as static

2017-01-18 Thread Brandon Williams
On 01/18, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Brandon, > > If you need to re-roll your 'bw/attr' branch, could you please > squash this into the relevant patch (commit 8908457159, > "attr: use hashmap for attribute dictionary", 12-01-2017). > > Also, I note that, a

[PATCH] attr: mark a file-local symbol as static

2017-01-18 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Brandon, If you need to re-roll your 'bw/attr' branch, could you please squash this into the relevant patch (commit 8908457159, "attr: use hashmap for attribute dictionary", 12-01-2017). Also, I note that, although they are declared as part of the public attr

Re: [PATCH] attr: mark a file-local symbol as static

2016-11-14 Thread Stefan Beller
On Sun, Nov 13, 2016 at 8:42 AM, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Stefan, > > If you need to re-roll your 'sb/attr' branch, could you please > squash this into the relevant patch. will do. I have it applied locally > > Alternatively, since there is only a single

[PATCH] attr: mark a file-local symbol as static

2016-11-13 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Stefan, If you need to re-roll your 'sb/attr' branch, could you please squash this into the relevant patch. Alternatively, since there is only a single call site for git_attr() (on line #1005), you could perhaps remove git_attr() and inline that call. (Howeve