Re: [PATCH] archive-zip: add --text parameter

2015-03-05 Thread René Scharfe
Am 05.03.2015 um 03:16 schrieb Junio C Hamano: René Scharfe writes: No sign-off, yet, because I'm not sure we really need another option. E.g. --text=all doesn't seem to be actually useful, but it was easy to implement. Info-ZIP's zip always creates archives like --text=auto does, so perhaps

Re: [PATCH] archive-zip: add --text parameter

2015-03-05 Thread René Scharfe
Am 04.03.2015 um 22:13 schrieb René Scharfe: diff --git a/archive-zip.c b/archive-zip.c index 4bde019..3767940 100644 --- a/archive-zip.c +++ b/archive-zip.c @@ -5,6 +5,7 @@ #include "archive.h" #include "streaming.h" #include "utf8.h" +#include "xdiff-interface.h" static int zip_date;

Re: [PATCH] archive-zip: add --text parameter

2015-03-04 Thread Junio C Hamano
René Scharfe writes: > No sign-off, yet, because I'm not sure we really need another option. > E.g. --text=all doesn't seem to be actually useful, but it was easy to > implement. Info-ZIP's zip always creates archives like --text=auto > does, so perhaps we should make that our default behavior a

[PATCH] archive-zip: add --text parameter

2015-03-04 Thread René Scharfe
Entries in a ZIP file can be marked as text files. Extractors can use that flag to apply end-of-line conversions. An example is unzip -a. git archive currently marks all ZIP file entries as binary files. This patch adds the new option --text that can be used to mark non-binary files or all file