On Wed, Dec 19, 2012 at 05:20:35PM -0500, Jeff King wrote:
> > > Do we want to change the variable name and invert the logic?
> >
> > That would be my preference.
> > [...]
> That's fine. I'll send out a revised version, and you can pick it up
> later.
Here it is.
-- >8 --
Subject: [PATCH] add
On Wed, Dec 19, 2012 at 02:16:52PM -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> >> Will queue; thanks.
> >
> > Do we want to change the variable name and invert the logic?
>
> That would be my preference.
>
> I am deep into today's integration cycle, and this PATHSPEC_GLOB
> version is
Jeff King writes:
>> Will queue; thanks.
>
> Do we want to change the variable name and invert the logic?
That would be my preference.
I am deep into today's integration cycle, and this PATHSPEC_GLOB
version is sitting at the tip of 'pu', so today's pushout will
contain that version, though.
--
On Wed, Dec 19, 2012 at 02:00:03PM -0800, Junio C Hamano wrote:
> > Subject: add GIT_PATHSPEC_GLOB environment variable
>
> Seems cleanly done from a quick look.
>
> Given that the normal mode of operation is to use globbing, I
> suspect that the names would have been more natural if the toggle
Jeff King writes:
> I included the common_prefix fix you mentioned (I do not think it
> produced incorrect results as it was, but it did not take full advantage
> of an optimization).
I do not think it would have affected the outcome; you would only
have worked with more cycles.
> Subject: add
On Wed, Dec 19, 2012 at 04:09:19PM -0500, Jeff King wrote:
> It's perhaps a better match to make it an environment variable. Then it
> is tied to a particular flow of execution, rather than having it be a
> property of a system, user, or repo (which is what config does). So for
> my restricted env
6 matches
Mail list logo
