Re: [PATCH] add--interactive: respect diff.compactionHeuristic

2016-06-16 Thread Jeff King
On Thu, Jun 16, 2016 at 09:50:45AM -0700, Stefan Beller wrote: > > -- >8 -- > > Subject: add--interactive: respect diff.compactionHeuristic > > > > We use plumbing to generate the diff, so it doesn't > > automatically pick up UI config like compactionHeuristic. > > Let's forward it on, since inter

Re: [PATCH] add--interactive: respect diff.compactionHeuristic

2016-06-16 Thread Stefan Beller
On Thu, Jun 16, 2016 at 5:27 AM, Jeff King wrote: > On Wed, Jun 15, 2016 at 08:24:47AM +0200, Alex Prengère wrote: > >> I see, it makes sense ;-) Indeed it would seem logical to have all >> commands showing diffs (diff, add -p, log -p, reset -p, etc..) respect >> the diff options. > > Here's a pat

[PATCH] add--interactive: respect diff.compactionHeuristic

2016-06-16 Thread Jeff King
On Wed, Jun 15, 2016 at 08:24:47AM +0200, Alex Prengère wrote: > I see, it makes sense ;-) Indeed it would seem logical to have all > commands showing diffs (diff, add -p, log -p, reset -p, etc..) respect > the diff options. Here's a patch to do so, similar to what we do for diff.algorithm. -- >