Re: [PATCH] Windows: only add a no-op pthread_sigmask() when needed

2016-05-11 Thread Junio C Hamano
Johannes Schindelin writes: > So I guess that you're preferring my 2. above. Going on that assumption, I > will send out another iteration. OK. >> Also is >> https://lists.gnu.org/archive/html/bug-gnulib/2015-04/msg00068.html >> relevant? Does /mingw64/x86_64-w64-mingw32/include/ implement "ma

Re: [PATCH] Windows: only add a no-op pthread_sigmask() when needed

2016-05-11 Thread Johannes Schindelin
Hi Junio, On Tue, 10 May 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > In f924b52 (Windows: add pthread_sigmask() that does nothing, > > 2016-05-01), we introduced a no-op for Windows. However, this breaks > > building Git in Git for Windows' SDK because pthread_sigmask() is >

Re: [PATCH] Windows: only add a no-op pthread_sigmask() when needed

2016-05-10 Thread Junio C Hamano
Johannes Schindelin writes: > In f924b52 (Windows: add pthread_sigmask() that does nothing, > 2016-05-01), we introduced a no-op for Windows. However, this breaks > building Git in Git for Windows' SDK because pthread_sigmask() is > already a no-op there, #define'd in the pthread_signal.h header

[PATCH] Windows: only add a no-op pthread_sigmask() when needed

2016-05-10 Thread Johannes Schindelin
In f924b52 (Windows: add pthread_sigmask() that does nothing, 2016-05-01), we introduced a no-op for Windows. However, this breaks building Git in Git for Windows' SDK because pthread_sigmask() is already a no-op there, #define'd in the pthread_signal.h header in /mingw64/x86_64-w64-mingw32/include