Re: [PATCH] Updated C# userdiff patterns.

2014-04-27 Thread Marius Ungureanu
Heya, so I’ll add the patches in the next 2 emails. I’ve changed a bit the main body of the methods/constructors regex. Basically, I’ve made the first item after the modifiers optional. That’s the return type and it’s not used in any case by operator overloads or constructors/destructors. I also

Re: [PATCH] Updated C# userdiff patterns.

2014-04-27 Thread Marius Ungureanu
On 26 Apr 2014, at 21:50, Johannes Sixt wrote: > Am 26.04.2014 20:33, schrieb Marius Ungureanu: >> ... add as many unit tests I can. > > Great! Keep in mind that quantity is secondary. Quality counts. Obviously. By ‘as many’, I meant to cover all the cases here. >> I’ll start a new thread wit

Re: [PATCH] Updated C# userdiff patterns.

2014-04-26 Thread Johannes Sixt
Am 26.04.2014 20:33, schrieb Marius Ungureanu: > ... add as many unit tests I can. Great! Keep in mind that quantity is secondary. Quality counts. > I’ll start a new thread with the new > patch as soon as I’m done with it. If possible, do not start a new thread, but post your new patch as a repl

Re: [PATCH] Updated C# userdiff patterns.

2014-04-26 Thread Marius Ungureanu
On 26 Apr 2014, at 20:49, Johannes Sixt wrote: > Am 26.04.2014 11:55, schrieb Marius Ungureanu: >> On 26 Apr 2014, at 10:10, Johannes Sixt wrote: >>> Am 26.04.2014 01:25, schrieb Marius Ungureanu: diff --git a/userdiff.c b/userdiff.c index fad52d6..7612c5d 100644 --- a/userdiff.c >

Re: [PATCH] Updated C# userdiff patterns.

2014-04-26 Thread Johannes Sixt
Am 26.04.2014 11:55, schrieb Marius Ungureanu: > On 26 Apr 2014, at 10:10, Johannes Sixt wrote: >> Am 26.04.2014 01:25, schrieb Marius Ungureanu: >>> diff --git a/userdiff.c b/userdiff.c >>> index fad52d6..7612c5d 100644 >>> --- a/userdiff.c >>> +++ b/userdiff.c >>> @@ -133,14 +133,14 @@ PATTERNS(

Re: [PATCH] Updated C# userdiff patterns.

2014-04-26 Thread Marius Ungureanu
On a side note, I noticed some of the keywords I added shouldn’t be there. I just realised that simple statements have no reason to be there, but only block definitions. I’ll reduce the size of this patch on the keywords part. Thanks, Marius-- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH] Updated C# userdiff patterns.

2014-04-26 Thread Marius Ungureanu
On 26 Apr 2014, at 10:10, Johannes Sixt wrote: > Am 26.04.2014 01:25, schrieb Marius Ungureanu: >> New keywords: foreach, break, in, try, finally, as, is, typeof, var, >> default, fixed, checked, unchecked, this, lock, readonly, unsafe, >> ref, out, base, null, delegate, continue. >> >> Removed

Re: [PATCH] Updated C# userdiff patterns.

2014-04-26 Thread Johannes Sixt
Am 26.04.2014 01:25, schrieb Marius Ungureanu: > New keywords: foreach, break, in, try, finally, as, is, typeof, var, > default, fixed, checked, unchecked, this, lock, readonly, unsafe, > ref, out, base, null, delegate, continue. > > Removed keywords: instanceof. It's only in Java. > Moved keyword

[PATCH] Updated C# userdiff patterns.

2014-04-25 Thread Marius Ungureanu
New keywords: foreach, break, in, try, finally, as, is, typeof, var, default, fixed, checked, unchecked, this, lock, readonly, unsafe, ref, out, base, null, delegate, continue. Removed keywords: instanceof. It's only in Java. Moved keywords to happen before modifier parsing, as matching a keyword