Re: [PATCH] Update diff-highlight

2016-02-26 Thread Roberto Tyley
On 22 February 2016 at 04:49, Eric Sunshine wrote: > On Sun, Feb 21, 2016 at 11:14 PM, Peter Dave Hello > wrote: >> From: Peter Dave Hello > > This "From:" line looks suspiciously incorrect. If anything, you'd > probably want to drop the line altogether or use: > > From: Peter Dave Hello P

Re: [PATCH] Update diff-highlight

2016-02-21 Thread Junio C Hamano
Peter Dave Hello writes: > From: Peter Dave Hello > > Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl` Even though there are existing examples in contrib/ parts that use this pattern, we try to avoid use of #!/usr/bin/env in more serious parts of our system. This is to control the exact

Re: [PATCH] Update diff-highlight

2016-02-21 Thread Peter Dave Hello
Hello Eric, Thanks for your review and prompt reply, this is my first PR to git, I'll try to update it to follow the conventions. Best, Peter -- Now you can follow me on twitter or GitHub :D 2016-02-22 12:49 GMT+08:00 Eric Sunshine : > On Sun, Feb 21, 2016 at 11:14 PM, Peter Dave Hello > wro

Re: [PATCH] Update diff-highlight

2016-02-21 Thread Eric Sunshine
On Sun, Feb 21, 2016 at 11:14 PM, Peter Dave Hello wrote: > From: Peter Dave Hello This "From:" line looks suspiciously incorrect. If anything, you'd probably want to drop the line altogether or use: From: Peter Dave Hello > Update diff-highlight Patches do indeed "update" the project, b

[PATCH] Update diff-highlight

2016-02-21 Thread Peter Dave Hello
From: Peter Dave Hello Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl` So that it can works on FreeBSD. --- contrib/diff-highlight/diff-highlight | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight/diff-highl