Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo

2016-02-03 Thread Eric Sunshine
On Wed, Feb 3, 2016 at 3:21 AM, Dan Aloni wrote: > On Tue, Feb 02, 2016 at 10:56:48PM -0500, Jeff King wrote: >> On Tue, Feb 02, 2016 at 09:54:21PM +0200, Dan Aloni wrote: >> > + if (strict && email && !strcmp(email, "(per-repo)")) { >> > + die("email is '(per-repo)', suggesting to set

Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo

2016-02-03 Thread Dan Aloni
(resend - my mailer was misconfigured) On Tue, Feb 02, 2016 at 10:56:48PM -0500, Jeff King wrote: > On Tue, Feb 02, 2016 at 09:54:21PM +0200, Dan Aloni wrote: >[..] > > + if (strict && email && !strcmp(email, "(per-repo)")) { > > + die("email is '(per-repo)', suggesting to set specific

Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo

2016-02-03 Thread Junio C Hamano
Jeff King writes: > Just when I dare to think "somebody cannot possibly be relying on this > arcane behavior", I am proven wrong. :) My thoughts, exactly. This is the kind of thing that makes this project uncomfortably "interesting"; we cannot make improvements without risking breaking existing

Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo

2016-02-02 Thread Jeff King
On Wed, Feb 03, 2016 at 12:26:36PM +0700, Duy Nguyen wrote: > >> Should we generalize this use case, i.e. define a list of > >> configuration variables that must be (re-)defined per-repo? Maybe not > >> worth it, I don't know. I can't think of any other variable that > >> should behave this way of

Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo

2016-02-02 Thread Duy Nguyen
On Wed, Feb 3, 2016 at 12:22 PM, Jeff King wrote: > On Wed, Feb 03, 2016 at 12:19:20PM +0700, Duy Nguyen wrote: > >> On Wed, Feb 3, 2016 at 10:56 AM, Jeff King wrote: >> > I find it disappointing that we go back to looking for magic sequences >> > in the string. Could we perhaps do this more clea

Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo

2016-02-02 Thread Jeff King
On Wed, Feb 03, 2016 at 12:19:20PM +0700, Duy Nguyen wrote: > On Wed, Feb 3, 2016 at 10:56 AM, Jeff King wrote: > > I find it disappointing that we go back to looking for magic sequences > > in the string. Could we perhaps do this more cleanly with a new config > > option? Like a "user.guessIdent

Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo

2016-02-02 Thread Duy Nguyen
On Wed, Feb 3, 2016 at 10:56 AM, Jeff King wrote: > I find it disappointing that we go back to looking for magic sequences > in the string. Could we perhaps do this more cleanly with a new config > option? Like a "user.guessIdent" which defaults to true, but people can > set to false. And without

Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo

2016-02-02 Thread Jeff King
On Tue, Feb 02, 2016 at 09:54:21PM +0200, Dan Aloni wrote: > Previously, before 5498c57cdd63, many people did the following: > >git config --global user.email "(none)" > > This was helpful for people with more than one E-Mail address, > targeting different E-Mail addresses for different clon

[PATCH] Trick to force setup of a specific configured E-Mail per repo

2016-02-02 Thread Dan Aloni
Previously, before 5498c57cdd63, many people did the following: git config --global user.email "(none)" This was helpful for people with more than one E-Mail address, targeting different E-Mail addresses for different clones. as it barred git from creating commit unless the user.email config w