Josh Triplett writes:
> I'd suggest squashing in an *additional* patch to the testsuite to
> ensure the presence of the blank line:
Thanks, will do.
> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index 535857e..8d90a6e 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-f
On Wed, Sep 14, 2016 at 03:57:36PM -0700, Junio C Hamano wrote:
> Junio C Hamano writes:
>
> > I do not mind doing it myself, but I am already in today's
> > integration cycle (which will merge a handful of topics to
> > 'master'), so I won't get around to it for some time. If you are
> > inclin
Junio C Hamano writes:
> I do not mind doing it myself, but I am already in today's
> integration cycle (which will merge a handful of topics to
> 'master'), so I won't get around to it for some time. If you are
> inclined to, please be my guest ;-)
I queued this on top for now; I think it can
Josh Triplett writes:
> It doesn't seem like a functional issue, but aesthetically it
> doesn't look good.
>
> Do you plan to make that change to print an additional blank line
> (likely inside print_bases), or should I?
I do not mind doing it myself, but I am already in today's
integration cycl
On Fri, Sep 09, 2016 at 01:51:04PM -0700, Junio C Hamano wrote:
> Josh Triplett writes:
>
> > On Fri, Sep 09, 2016 at 12:41:56PM -0700, Junio C Hamano wrote:
> >> So here is a suggested replacement. I notice that in the MIME case,
> >> we do not leave any blank line between the last line of the
Josh Triplett writes:
> On Fri, Sep 09, 2016 at 12:41:56PM -0700, Junio C Hamano wrote:
>> So here is a suggested replacement. I notice that in the MIME case,
>> we do not leave any blank line between the last line of the patch
>> and the baseinfo, which makes it look a bit strange, e.g. output
On Fri, Sep 09, 2016 at 12:41:56PM -0700, Junio C Hamano wrote:
> So here is a suggested replacement. I notice that in the MIME case,
> we do not leave any blank line between the last line of the patch
> and the baseinfo, which makes it look a bit strange, e.g. output of
> "format-patch --attach=m
Junio C Hamano writes:
> Jeff King writes:
>
>> On Thu, Sep 08, 2016 at 11:54:08AM -0700, Josh Triplett wrote:
>>
>>> > your problem description
>>> > looks perfect. I am still not sure if the code does a reasonable
>>> > thing in MIME case, though.
>>>
>>> It *looks* correct to me.
>>
>> Hmm
Jeff King writes:
> On Thu, Sep 08, 2016 at 11:54:08AM -0700, Josh Triplett wrote:
>
>> > your problem description
>> > looks perfect. I am still not sure if the code does a reasonable
>> > thing in MIME case, though.
>>
>> It *looks* correct to me.
>
> Hmm. It looks correct to me, too; ...
>
On Thu, Sep 08, 2016 at 11:54:08AM -0700, Josh Triplett wrote:
> > your problem description
> > looks perfect. I am still not sure if the code does a reasonable
> > thing in MIME case, though.
>
> It *looks* correct to me.
Hmm. It looks correct to me, too; we stick it just after the patch, so
w
Josh Triplett writes:
> If any other change ends up being necessary, I'll split the patch in v2.
Thanks. I do not see anything else offhand myself, but other people
watching the topic from the sideline may spot something we missed.
On Thu, Sep 08, 2016 at 11:34:15AM -0700, Junio C Hamano wrote:
> Josh Triplett writes:
>
> > Any text below the "-- " for the email signature gets treated as part of
> > the signature, and many mail clients will trim it from the quoted text
> > for a reply. Move it above the signature, so peopl
Josh Triplett writes:
> Any text below the "-- " for the email signature gets treated as part of
> the signature, and many mail clients will trim it from the quoted text
> for a reply. Move it above the signature, so people can reply to it
> more easily.
>
> Add tests for the exact format of the
Any text below the "-- " for the email signature gets treated as part of
the signature, and many mail clients will trim it from the quoted text
for a reply. Move it above the signature, so people can reply to it
more easily.
Add tests for the exact format of the email signature, and add tests to
14 matches
Mail list logo
