Re: [PATCH] Makefile: do not compile git with debugging symbols by default

2015-01-27 Thread David Aguilar
On Fri, Jan 23, 2015 at 07:55:17AM +0900, Mike Hommey wrote: > On Thu, Jan 22, 2015 at 01:35:38PM -0500, Jeff King wrote: > > On Thu, Jan 22, 2015 at 06:36:41PM +0100, Matthieu Moy wrote: > > > > > > Yes, main point is size of executable. > > > > > > The Git executable is a few megabytes, i.e. 0.

Re: [PATCH] Makefile: do not compile git with debugging symbols by default

2015-01-22 Thread Mike Hommey
On Thu, Jan 22, 2015 at 01:35:38PM -0500, Jeff King wrote: > On Thu, Jan 22, 2015 at 06:36:41PM +0100, Matthieu Moy wrote: > > > > Yes, main point is size of executable. > > > > The Git executable is a few megabytes, i.e. 0.001% the size of a really > > small hard disk. The benefit seems really n

Re: [PATCH] Makefile: do not compile git with debugging symbols by default

2015-01-22 Thread Jeff King
On Thu, Jan 22, 2015 at 06:36:41PM +0100, Matthieu Moy wrote: > > Yes, main point is size of executable. > > The Git executable is a few megabytes, i.e. 0.001% the size of a really > small hard disk. The benefit seems really negligible to me. I don't know the layout of the symbols with respect t

Re: [PATCH] Makefile: do not compile git with debugging symbols by default

2015-01-22 Thread Matthieu Moy
Alexander Kuleshov writes: > Hello Jeff, > > Yes, main point is size of executable. The Git executable is a few megabytes, i.e. 0.001% the size of a really small hard disk. The benefit seems really negligible to me. OTOH, debug information allow users to do better bug reports in case of crash (

Re: [PATCH] Makefile: do not compile git with debugging symbols by default

2015-01-22 Thread Alexander Kuleshov
Or even still -g as it now, because anyway debugging info will be removed with stripping 2015-01-22 22:51 GMT+06:00 Alexander Kuleshov : > Hello Jeff, > > Yes, main point is size of executable. I'm sorry, didn't see 'strip' target. > > What if we will strip git and other executable files by defaul

Re: [PATCH] Makefile: do not compile git with debugging symbols by default

2015-01-22 Thread Alexander Kuleshov
Hello Jeff, Yes, main point is size of executable. I'm sorry, didn't see 'strip' target. What if we will strip git and other executable files by default and add -g option and don't strip it if DEBUG=1 passed to make. Something like this: git$X: git.o GIT-LDFLAGS $(BUILTIN_OBJS) $(GITLIBS) $

Re: [PATCH] Makefile: do not compile git with debugging symbols by default

2015-01-22 Thread Mike Hommey
On Thu, Jan 22, 2015 at 08:00:36AM -0500, Jeff King wrote: > On Thu, Jan 22, 2015 at 06:50:37PM +0600, Alexander Kuleshov wrote: > > > Standard user has no need in debugging information. This patch adds > > DEBUG=1 option to compile git with debugging symbols and compile without > > it by default.

Re: [PATCH] Makefile: do not compile git with debugging symbols by default

2015-01-22 Thread Jeff King
On Thu, Jan 22, 2015 at 06:50:37PM +0600, Alexander Kuleshov wrote: > Standard user has no need in debugging information. This patch adds > DEBUG=1 option to compile git with debugging symbols and compile without > it by default. This explanation is missing why it is beneficial _not_ to have the

[PATCH] Makefile: do not compile git with debugging symbols by default

2015-01-22 Thread Alexander Kuleshov
Standard user has no need in debugging information. This patch adds DEBUG=1 option to compile git with debugging symbols and compile without it by default. Signed-off-by: Alexander Kuleshov --- Makefile | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefi