Re: [PATCH] Makefile: add NO_CLOCK_GETTIME check

2014-09-03 Thread Junio C Hamano
Junio C Hamano writes: >> +ifndef NO_CLOCK_GETTIME >> ifdef HAVE_CLOCK_GETTIME >> BASIC_CFLAGS += -DHAVE_CLOCK_GETTIME >> EXTLIBS += -lrt >> endif >> +endif > > I am not sure why you even need this change. Wouldn't you get > exactly the same result if you did not define HAVE_CLOCK_GE

Re: [PATCH] Makefile: add NO_CLOCK_GETTIME check

2014-09-03 Thread Junio C Hamano
Reuben Hawkins writes: > Some really old platforms, rhel3, which don't define CLOCK_MONOTONIC, still > need a way to build git. Some high resolution timer code was added Jul 12, > 2014 to aid debugging performance issues. That code uses clock_gettime and > CLOCK_MONOTONIC. That change breaks b

[PATCH] Makefile: add NO_CLOCK_GETTIME check

2014-09-03 Thread Reuben Hawkins
Some really old platforms, rhel3, which don't define CLOCK_MONOTONIC, still need a way to build git. Some high resolution timer code was added Jul 12, 2014 to aid debugging performance issues. That code uses clock_gettime and CLOCK_MONOTONIC. That change breaks building git on ancient platforms