Re: [PATCH] Make running git under other debugger-like programs easy

2018-04-06 Thread Elijah Newren
Hi Dscho, On Fri, Apr 6, 2018 at 3:38 AM, Johannes Schindelin wrote: > On Thu, 5 Apr 2018, Elijah Newren wrote: >> On Thu, Apr 5, 2018 at 12:57 PM, Johannes Schindelin >> wrote: >> That all looks great to me. But at this point, it seems like it's a >> full rewrite and your patch to submit (w

Re: [PATCH] Make running git under other debugger-like programs easy

2018-04-06 Thread Johannes Schindelin
Hi Elijah, On Thu, 5 Apr 2018, Elijah Newren wrote: > On Thu, Apr 5, 2018 at 12:57 PM, Johannes Schindelin > wrote: > > > I wonder whether a better approach would be to add an optional argument to > > that `debug` function (which is intended to have `git` as first argument, > > anyway, or at le

Re: [PATCH] Make running git under other debugger-like programs easy

2018-04-05 Thread Elijah Newren
Hi Johannes, On Thu, Apr 5, 2018 at 12:57 PM, Johannes Schindelin wrote: > I wonder whether a better approach would be to add an optional argument to > that `debug` function (which is intended to have `git` as first argument, > anyway, or at least a command/function that does not start with a da

Re: [PATCH] Make running git under other debugger-like programs easy

2018-04-05 Thread Johannes Schindelin
Hi Elijah, On Thu, 5 Apr 2018, Elijah Newren wrote: > This allows us to run git, when using the script from bin-wrappers, under > other programs. A few examples: >GIT_WRAPPER=nemiver git $ARGS >GIT_WRAPPER="valgrind --tool=memcheck --track-origins=yes" git $ARGS > > Yes, we already have

[PATCH] Make running git under other debugger-like programs easy

2018-04-05 Thread Elijah Newren
This allows us to run git, when using the script from bin-wrappers, under other programs. A few examples: GIT_WRAPPER=nemiver git $ARGS GIT_WRAPPER="valgrind --tool=memcheck --track-origins=yes" git $ARGS Yes, we already have GIT_TEST_GDB (which could potentially be replaced with GIT_WRAPPE