Re: [PATCH] Make fread/fwrite-like functions in http.c more like fread/fwrite.

2019-05-07 Thread Jeff King
On Tue, May 07, 2019 at 04:58:32PM +0200, SZEDER Gábor wrote: > On Wed, May 01, 2019 at 05:56:35PM +0900, Mike Hommey wrote: > > The fread/fwrite-like functions in http.c, namely fread_buffer, > > fwrite_buffer, fwrite_null, fwrite_sha1_file all return the > > multiplication of the size and number

Re: [PATCH] Make fread/fwrite-like functions in http.c more like fread/fwrite.

2019-05-07 Thread SZEDER Gábor
On Wed, May 01, 2019 at 05:56:35PM +0900, Mike Hommey wrote: > The fread/fwrite-like functions in http.c, namely fread_buffer, > fwrite_buffer, fwrite_null, fwrite_sha1_file all return the > multiplication of the size and number of items they are being given. > > Practically speaking, it doesn't m

Re: [PATCH] Make fread/fwrite-like functions in http.c more like fread/fwrite.

2019-05-01 Thread Jeff King
On Wed, May 01, 2019 at 05:56:35PM +0900, Mike Hommey wrote: > The fread/fwrite-like functions in http.c, namely fread_buffer, > fwrite_buffer, fwrite_null, fwrite_sha1_file all return the > multiplication of the size and number of items they are being given. > > Practically speaking, it doesn't

[PATCH] Make fread/fwrite-like functions in http.c more like fread/fwrite.

2019-05-01 Thread Mike Hommey
The fread/fwrite-like functions in http.c, namely fread_buffer, fwrite_buffer, fwrite_null, fwrite_sha1_file all return the multiplication of the size and number of items they are being given. Practically speaking, it doesn't matter, because in all contexts where those functions are used, size is