Re: [PATCH] Make find_commit_subject() more robust

2016-06-22 Thread Johannes Schindelin
Hi Junio, On Tue, 21 Jun 2016, Junio C Hamano wrote: > Your patch introduces a similar loop with similar (but different) > purpose: > > while (*p == '\n') > p++; > > which would have been helped if there were a helper with an > opposite function, i.e. > >

Re: [PATCH] Make find_commit_subject() more robust

2016-06-21 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Mon, 20 Jun 2016, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > Just like the pretty printing machinery, we should simply ignore empty >> > lines at the beginning of the commit messages. >> > >> > This discrepancy was noticed when

Re: [PATCH] Make find_commit_subject() more robust

2016-06-21 Thread Johannes Schindelin
Hi Junio, On Mon, 20 Jun 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Just like the pretty printing machinery, we should simply ignore empty > > lines at the beginning of the commit messages. > > > > This discrepancy was noticed when an early version of the rebase--helper > >

Re: [PATCH] Make find_commit_subject() more robust

2016-06-20 Thread Junio C Hamano
Johannes Schindelin writes: > Just like the pretty printing machinery, we should simply ignore empty > lines at the beginning of the commit messages. > > This discrepancy was noticed when an early version of the rebase--helper > produced commit objects with more than one empty line between the he

[PATCH] Make find_commit_subject() more robust

2016-06-18 Thread Johannes Schindelin
Just like the pretty printing machinery, we should simply ignore empty lines at the beginning of the commit messages. This discrepancy was noticed when an early version of the rebase--helper produced commit objects with more than one empty line between the header and the commit message. Signed-of