Re: [PATCH] Make error message after failing commit_lock_file() less confusing

2015-12-03 Thread SZEDER Gábor
Quoting Eric Sunshine : diff --git a/config.c b/config.c @@ -64,7 +64,8 @@ static void rewrite_credential_file(const char *fn, struct credential *c, print_line(extra); parse_credential_file(fn, c, NULL, print_line); if (commit_lock_file(&credential_lock) < 0)

Re: [PATCH] Make error message after failing commit_lock_file() less confusing

2015-12-01 Thread Eric Sunshine
On Mon, Nov 30, 2015 at 6:40 AM, SZEDER Gábor wrote: > The error message after a failing commit_lock_file() call sometimes > looks like this, causing confusion: > > $ git remote add remote g...@server.com/repo.git > error: could not commit config file .git/config > # Huh?! > # I didn't wan

Re: [PATCH] Make error message after failing commit_lock_file() less confusing

2015-12-01 Thread Junio C Hamano
Jeff King writes: > On Mon, Nov 30, 2015 at 12:40:53PM +0100, SZEDER Gábor wrote: > >> The error message after a failing commit_lock_file() call sometimes >> looks like this, causing confusion: >> >> $ git remote add remote g...@server.com/repo.git >> error: could not commit config file .git

Re: [PATCH] Make error message after failing commit_lock_file() less confusing

2015-12-01 Thread Jeff King
On Mon, Nov 30, 2015 at 12:40:53PM +0100, SZEDER Gábor wrote: > The error message after a failing commit_lock_file() call sometimes > looks like this, causing confusion: > > $ git remote add remote g...@server.com/repo.git > error: could not commit config file .git/config > # Huh?! > # I

[PATCH] Make error message after failing commit_lock_file() less confusing

2015-11-30 Thread SZEDER Gábor
The error message after a failing commit_lock_file() call sometimes looks like this, causing confusion: $ git remote add remote g...@server.com/repo.git error: could not commit config file .git/config # Huh?! # I didn't want to commit anything, especially not my config file! While in the