Re: [PATCH] Improvement to only call Git Credential Helper once

2018-09-29 Thread Jeff King
On Sat, Sep 29, 2018 at 12:06:38PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Wow, what's old is new again. Here's more or less the same patch from > > 2012: > > > > https://public-inbox.org/git/20120407033417.ga13...@sigill.intra.peff.net/ > > > > Unfortunately, some people seem t

Re: [PATCH] Improvement to only call Git Credential Helper once

2018-09-29 Thread Junio C Hamano
Jeff King writes: > Wow, what's old is new again. Here's more or less the same patch from > 2012: > > https://public-inbox.org/git/20120407033417.ga13...@sigill.intra.peff.net/ > > Unfortunately, some people seem to rely on this multi-helper behavior. I > recommend reading the whole thread, as

Re: [PATCH] Improvement to only call Git Credential Helper once

2018-09-29 Thread Jeff King
On Fri, Sep 28, 2018 at 12:37:16PM -0400, Kyle Hubert wrote: > When calling the Git Credential Helper that is set in the git config, > the get command can return a credential. Git immediately turns around > and calls the store command, even though that credential was just > retrieved by the Helper

Re: [PATCH] Improvement to only call Git Credential Helper once

2018-09-28 Thread Kyle Hubert
Thank you for the review, commenting inline. On Fri, Sep 28, 2018 at 3:29 PM Junio C Hamano wrote: > Kyle Hubert writes: > > > Subject: Re: [PATCH] Improvement to only call Git Credential Helper once > > Nobody will send in a patch to worsen things, so phrases like >

Re: [PATCH] Improvement to only call Git Credential Helper once

2018-09-28 Thread Junio C Hamano
Kyle Hubert writes: > Subject: Re: [PATCH] Improvement to only call Git Credential Helper once Nobody will send in a patch to worsen things, so phrases like "Improvement to" that convey no useful information has no place on the title. There probably are multiple ways that crede

[PATCH] Improvement to only call Git Credential Helper once

2018-09-28 Thread Kyle Hubert
When calling the Git Credential Helper that is set in the git config, the get command can return a credential. Git immediately turns around and calls the store command, even though that credential was just retrieved by the Helper. This creates two side effects. First of all, if the Helper requires

Re: [PATCH] Improvement to only call Git Credential Helper once

2018-09-28 Thread Kyle Hubert
Sorry, this patch is damaged. I'm moving to `git send-email` now. -Kyle On Fri, Sep 28, 2018 at 11:10 AM Kyle Hubert wrote: > > When calling the Git Credential Helper that is set in the git config, > the get command can return a credential. Git immediately turns around > and calls the store comm

[PATCH] Improvement to only call Git Credential Helper once

2018-09-28 Thread Kyle Hubert
When calling the Git Credential Helper that is set in the git config, the get command can return a credential. Git immediately turns around and calls the store command, even though that credential was just retrieved by the Helper. This creates two side effects. First of all, if the Helper requires