Re: [PATCH] Git::SVN: handle missing ref_id case correctly

Ramkumar Ramachandra wrote: >> It is functional, maybe someone will use GIT_SVN_ID=0 ? > > Right. Kindly drop the first hunk. Amendment: there are actually many other places where variables are checked without "defined", so I doubt we want to put up with the extra ugliness to allow "0". -- To unsu

Re: [PATCH] Git::SVN: handle missing ref_id case correctly

Eric Wong wrote: > It is functional, maybe someone will use GIT_SVN_ID=0 ? Right. Kindly drop the first hunk. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Git::SVN: handle missing ref_id case correctly

Ramkumar Ramachandra wrote: > Ramkumar Ramachandra wrote: > > -our $default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn'; > > +our $default_ref_id = defined $ENV{GIT_SVN_ID} ? $ENV{GIT_SVN_ID} : > > 'git-svn'; > > This is probably not a functional change; please look at the second hunk. It is funct

Re: [PATCH] Git::SVN: handle missing ref_id case correctly

Ramkumar Ramachandra wrote: > -our $default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn'; > +our $default_ref_id = defined $ENV{GIT_SVN_ID} ? $ENV{GIT_SVN_ID} : > 'git-svn'; This is probably not a functional change; please look at the second hunk. -- To unsubscribe from this list: send the line "unsu

[PATCH] Git::SVN: handle missing ref_id case correctly

$ENV{GIT_SVN_ID} will return a string, so check it with defined. Also, ref_id should not match "refs/remotes/". Signed-off-by: Ramkumar Ramachandra --- perl/Git/SVN.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm index d9a52a5..06ff216