Re: [PATCH] Get correct column with for options in command usage

2013-02-05 Thread Junio C Hamano
Duy Nguyen writes: > On Tue, Feb 5, 2013 at 7:15 PM, Duy Nguyen wrote: >> + fprintf(outfile, sb.buf); > > Use fputs instead. I looked up fputs man page but somehow still left > fprintf there. Once the streams of "oops that was wrong" comments are done, I'd appreciate if one of you guys se

Re: [PATCH] Get correct column with for options in command usage

2013-02-05 Thread Duy Nguyen
On Tue, Feb 5, 2013 at 7:15 PM, Duy Nguyen wrote: > + fprintf(outfile, sb.buf); Use fputs instead. I looked up fputs man page but somehow still left fprintf there. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] Get correct column with for options in command usage

2013-02-05 Thread Duy Nguyen
On Tue, Feb 05, 2013 at 03:40:32PM +0800, Jiang Xin wrote: > Command usage would not align well if command options are translated, > especially to CJK. Call utf8_strwidth in function usage_argh, so that > the caller will get correct column width. Yeah, I just noticed a misalignment in Vietnamese t

[PATCH] Get correct column with for options in command usage

2013-02-04 Thread Jiang Xin
Command usage would not align well if command options are translated, especially to CJK. Call utf8_strwidth in function usage_argh, so that the caller will get correct column width. Signed-off-by: Jiang Xin --- parse-options.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --g