Re: [PATCH] Fixing unclear messages

2014-08-11 Thread Alexander Shopov
> If there were something else "Huh?" could mean after you > give a response to that prompt, but I do not think there is. OK, you love your "Huh"s. Good for you. I cannot find a convincing argument then. > If I were asked to say what it is then, I would say "it reassures". It is like a jewel you f

Re: [PATCH] Fixing unclear messages

2014-08-11 Thread Junio C Hamano
Alexander Shopov writes: >>> - printf_ln(_("Huh (%s)?"), (*ptr)->buf); >>> + printf_ln(_("Wrong choice (%s). Choose again."), >>> (*ptr)->buf); >> Why is this an improvement? > Because 'Huh?' without intonation, gesture or a frown provided by a > human bei

Re: [PATCH] Fixing unclear messages

2014-08-11 Thread Alexander Shopov
>> - printf_ln(_("Huh (%s)?"), (*ptr)->buf); >> + printf_ln(_("Wrong choice (%s). Choose again."), >> (*ptr)->buf); > Why is this an improvement? Because 'Huh?' without intonation, gesture or a frown provided by a human being is hard to understand. It does n

Re: [PATCH] Fixing unclear messages

2014-08-10 Thread Junio C Hamano
Alexander Shopov writes: > diff --git a/builtin/clean.c b/builtin/clean.c > index 1032563..9f38068 100644 > --- a/builtin/clean.c > +++ b/builtin/clean.c > @@ -514,7 +514,7 @@ static int parse_choice(struct menu_stuff *menu_stuff, > if (top <= 0 || bottom <= 0 || top > menu_stuff->n

Re: [PATCH] Fixing unclear messages

2014-08-10 Thread Jeff King
On Sun, Aug 10, 2014 at 06:13:27PM +0300, Alexander Shopov wrote: > Signed-off-by: Alexander Shopov It would probably make sense to put the discussion from your cover letter into the commit message. > diff --git a/builtin/index-pack.c b/builtin/index-pack.c > index 5568a5b..d9c5911 100644 > ---

[PATCH] Fixing unclear messages

2014-08-10 Thread Alexander Shopov
Signed-off-by: Alexander Shopov --- builtin/clean.c | 2 +- builtin/commit.c | 2 +- builtin/index-pack.c | 4 ++-- builtin/log.c| 4 ++-- builtin/merge.c | 5 +++-- builtin/remote.c | 2 +- builtin/tag.c| 2 +- git-bisect.sh| 2 +- merge-recursive.c|