Re: [PATCH] Fix worktree usage message

2015-10-18 Thread Eric Sunshine
On Sun, Oct 18, 2015 at 8:15 AM, Sidhant Sharma wrote: > Mark optional in worktree command line usage to maintain consistency > with man pages. Thanks for the patch. To clarify that it is the in-code usage string which is incorrect, rather than the man page, how about something like the followi

[PATCH] Fix worktree usage message

2015-10-18 Thread Sidhant Sharma
Mark optional in worktree command line usage to maintain consistency with man pages. Reported-by: ch3co...@gmail.com Signed-off-by: Sidhant Sharma --- It was reported here: http://marc.info/?l=git&m=144514145804787&w=2 builtin/worktree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH] Fix worktree usage message

2015-10-18 Thread Kevin Daudt
On Sun, Oct 18, 2015 at 04:32:24PM +0530, Sidhant Sharma wrote: > Mark as optional in worktree command line usage. Thank you for the patch. Can you also explain why you mark it as optional in the commit message? That way it's clear why this patch is needed. > > Hi, just starting out with de

[PATCH] Fix worktree usage message

2015-10-18 Thread Sidhant Sharma
Mark as optional in worktree command line usage. Hi, just starting out with development for Git. Found this one super easy to fix, so made a patch :) --- builtin/worktree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/worktree.c b/builtin/worktree.c index 71bb770