Re: [PATCH] Fix urlencode format string on signed char.

Hi Julien, On Sat, 23 Dec 2017, Julien Dusser wrote: > Thank you for review. I didn't find any other error. > Code in http.c:quote_ref_url() is almost the same but ch is a signed int, so > there's no issue. But that ch comes from a signed char *, so it actually *is* an issue: if you cast a signe

Re: [PATCH] Fix urlencode format string on signed char.

Thank you for review. I didn't find any other error. Code in http.c:quote_ref_url() is almost the same but ch is a signed int, so there's no issue. Le 22/12/2017 à 22:48, Junio C Hamano a écrit : Julien Dusser writes: Git credential fails with special char in password. remote: Invalid usern

Re: [PATCH] Fix urlencode format string on signed char.

Julien Dusser writes: > Git credential fails with special char in password. > remote: Invalid username or password. > fatal: Authentication failed for > > File ~/.git-credential contains badly urlencoded characters > %ffXX%ffYY instead of %XX%YY. > > Add a cast to an unsigned char to fix

[PATCH] Fix urlencode format string on signed char.

Git credential fails with special char in password. remote: Invalid username or password. fatal: Authentication failed for File ~/.git-credential contains badly urlencoded characters %ffXX%ffYY instead of %XX%YY. Add a cast to an unsigned char to fix urlencode use of %02x on a char. Sign