Sebastian Schuberth writes:
> On Thu, Jan 2, 2014 at 10:08 PM, Junio C Hamano wrote:
>
>>> Seems like the path to clone to is taken as-is from argv in
>>> cmd_clone(). So maybe another solution would be to replace all
>>> backslashes with forward slashes already there?
>>
>> That sounds like a w
On Thu, Jan 2, 2014 at 10:08 PM, Junio C Hamano wrote:
>> Seems like the path to clone to is taken as-is from argv in
>> cmd_clone(). So maybe another solution would be to replace all
>> backslashes with forward slashes already there?
>
> That sounds like a workable alternative, and it might even
On Thu, Jan 2, 2014 at 10:19 PM, Johannes Schindelin
wrote:
>> and parsed to be stuffed into trees), it is fine to do so as long as all
>> the codepaths understands the new world order, but my earlier "git grep"
>> hits did not tell me that such a change is warranted.
>
> You call safe_create_lea
On Tue, Jan 7, 2014 at 6:56 PM, Johannes Schindelin
wrote:
>> > Well, you and I both know how easy GitHub's pull request made things
>> > for us as well as for contributors. I really cannot thank Erik enough
>> > for bullying me into using and accepting them.
>>
>> Huh? I don't think you refer to
Hi,
On Tue, 7 Jan 2014, Erik Faye-Lund wrote:
> On Thu, Jan 2, 2014 at 9:46 PM, Johannes Schindelin
> wrote:
>
> > Well, you and I both know how easy GitHub's pull request made things
> > for us as well as for contributors. I really cannot thank Erik enough
> > for bullying me into using and acc
On Thu, Jan 2, 2014 at 9:46 PM, Johannes Schindelin
wrote:
> Hi Sebastian,
>
> On Thu, 2 Jan 2014, Sebastian Schuberth wrote:
>
>> On 02.01.2014 18:33, Johannes Schindelin wrote:
>>
>> > -- snip --
>> > On Linux, we can get away with assuming that the directory separator is a
>> > forward slash, b
Hi Junio,
On Thu, 2 Jan 2014, Junio C Hamano wrote:
> If we are going to change the meaning of the function so that it can
> now take any random path in platform-specific convention
Note that nothing in the function name or documentation suggests
otherwise.
> that may be incompatible with the i
Sebastian Schuberth writes:
> On 02.01.2014 20:55, Junio C Hamano wrote:
>
>> Thanks; the conclusion is correct --- you need a good commit
>> message in the recorded history. That does not have anything to do
>> with integrating with pulling from subsystem maintainers, which we
>> regularly do.
On 02.01.2014 20:55, Junio C Hamano wrote:
> Thanks; the conclusion is correct --- you need a good commit
> message in the recorded history. That does not have anything to do
> with integrating with pulling from subsystem maintainers, which we
> regularly do.
I'll send a v2 which adds a proper c
Hi Sebastian,
On Thu, 2 Jan 2014, Sebastian Schuberth wrote:
> On 02.01.2014 18:33, Johannes Schindelin wrote:
>
> > -- snip --
> > On Linux, we can get away with assuming that the directory separator is a
> > forward slash, but that is wrong in general. For that purpose, the
> > is_dir_sep() fu
Hi Junio,
On Thu, 2 Jan 2014, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > On Thu, 2 Jan 2014, Sebastian Schuberth wrote:
> >
> >> See https://github.com/msysgit/git/pull/80.
> >
> > Thanks Sebastian!
> >
> > However, since the git.git project is not comfortable with the concept
>
On 02.01.2014 19:18, John Keeping wrote:
That said, I see any further explanations on top of the commit message
title is an added bonus, and as "just" a bonus a link to a pull request
should be fine. You don't need to understand or appreciate the concept
of pull requests in order to follow the l
Johannes Schindelin writes:
> Hi,
>
> On Thu, 2 Jan 2014, Sebastian Schuberth wrote:
>
>> See https://github.com/msysgit/git/pull/80.
>
> Thanks Sebastian!
>
> However, since the git.git project is not comfortable with the concept of
> pull requests (which is why you submitted this patch via mail
On Thu, Jan 02, 2014 at 07:11:42PM +0100, Sebastian Schuberth wrote:
> On 02.01.2014 18:33, Johannes Schindelin wrote:
>
> > -- snip --
> > On Linux, we can get away with assuming that the directory separator is a
> > forward slash, but that is wrong in general. For that purpose, the
> > is_dir_se
On 02.01.2014 18:33, Johannes Schindelin wrote:
-- snip --
On Linux, we can get away with assuming that the directory separator is a
forward slash, but that is wrong in general. For that purpose, the
is_dir_sep() function was introduced a long time ago. By using it in
safe_create_leading_directo
Hi,
On Thu, 2 Jan 2014, Sebastian Schuberth wrote:
> See https://github.com/msysgit/git/pull/80.
Thanks Sebastian!
However, since the git.git project is not comfortable with the concept of
pull requests (which is why you submitted this patch via mail), I believe
that we have to explain the rati
See https://github.com/msysgit/git/pull/80.
Signed-off-by: Johannes Schindelin
Signed-off-by: Sebastian Schuberth
---
sha1_file.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/sha1_file.c b/sha1_file.c
index 760dd60..2114c58 100644
--- a/sha1_file.c
+++ b/s
17 matches
Mail list logo
