Hi Martin,
On Tue, 8 Aug 2017, Martin Koegler wrote:
> On Mon, Aug 07, 2017 at 09:39:12PM +0200, Johannes Schindelin wrote:
> > If you want to work on data in memory, then size_t is the appropriate data
> > type. We already use it elsewhere. Let's use it here, too, without the
> > intermediate bu
On Mon, Aug 07, 2017 at 06:44:16PM -0700, Junio C Hamano wrote:
> Having said that, I am a bit curious how you came to this patch.
> Was the issue found by code inspection, or did you actually have a
> real life use case to raise the core.bigFileThreshold configuration
> to a value above 4GB?
Real
679dd939972c151bcf23c122cdc570 Mon Sep 17 00:00:00 2001
From: Martin Koegler
Date: Mon, 7 Aug 2017 20:00:30 +0200
Subject: [PATCH] Fix delta integer overflows
The current delta code produces incorrect pack objects for files > 4GB.
Signed-off-by: Martin Koegler
---
diff-delta.c | 24 +
Junio C Hamano writes:
> Martin Koegler writes:
>
>> From: Martin Koegler
>>
>> The current delta code produces incorrect pack objects for files > 4GB.
>>
>> Signed-off-by: Martin Koegler
>> ---
>> diff-delta.c | 23 ---
>> 1 file changed, 12 insertions(+), 11 deletions(-)
Junio C Hamano writes:
> This is not about where the bar is set. It is about expectation
After having thought about this a bit more, I think in the message I
am responding to I mischaracterised the aspect of a patch that
influences the "expectation". It is much less about who the
contribut
Johannes Schindelin writes:
> So are you saying that starting with v2.14.0, you accept patches into `pu`
> for which you would previously have required multiple iterations before
> even considering it for `pu`?
>
> Frankly, I am a bit surprised that this obvious change from `unsigned
> long` to `
Hi Junio,
On Mon, 7 Aug 2017, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> >> The patch obviously makes the code better and self consistent in
> >> that "struct delta_index" has src_size as ulong, and this function
> >> takes trg_size as ulong, and it was plain wrong for the code to
Johannes Schindelin writes:
>> The patch obviously makes the code better and self consistent in
>> that "struct delta_index" has src_size as ulong, and this function
>> takes trg_size as ulong, and it was plain wrong for the code to
>> assume that "i", which is uint, can receive it safely.
>>
>>
Hi,
On Mon, 7 Aug 2017, Junio C Hamano wrote:
> Martin Koegler writes:
>
> > From: Martin Koegler
> >
> > The current delta code produces incorrect pack objects for files > 4GB.
> >
> > Signed-off-by: Martin Koegler
> > ---
> > diff-delta.c | 23 ---
> > 1 file changed, 1
Martin Koegler writes:
> From: Martin Koegler
>
> The current delta code produces incorrect pack objects for files > 4GB.
>
> Signed-off-by: Martin Koegler
> ---
> diff-delta.c | 23 ---
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> Just pass any file > 4 GB to th
From: Martin Koegler
The current delta code produces incorrect pack objects for files > 4GB.
Signed-off-by: Martin Koegler
---
diff-delta.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
Just pass any file > 4 GB to the delta-compression [by increasing the del
11 matches
Mail list logo
