Re: [PATCH] Fix branch renaming not updating HEADs correctly

2017-08-26 Thread Junio C Hamano
Thanks. I'll merge this down to at least 'next' before I go offline for a week.

Re: [PATCH] Fix branch renaming not updating HEADs correctly

2017-08-24 Thread Nish Aravamudan
On 24.08.2017 [17:41:24 +0700], Nguyễn Thái Ngọc Duy wrote: > There are two bugs that sort of work together and cause problems. Let's > start with one in replace_each_worktree_head_symref. > Correct add_head_info(), remove RESOLVE_REF_READING flag. With the flag > gone, we should always return g

[PATCH] Fix branch renaming not updating HEADs correctly

2017-08-24 Thread Nguyễn Thái Ngọc Duy
There are two bugs that sort of work together and cause problems. Let's start with one in replace_each_worktree_head_symref. Before fa099d2322 (worktree.c: kill parse_ref() in favor of refs_resolve_ref_unsafe() - 2017-04-24), this code looks like this: if (strcmp(oldref, worktrees[i]->head_re