Re: [PATCH] Documentation: fix --color option formatting

2018-07-20 Thread Junio C Hamano
"brian m. carlson" writes: > Both AsciiDoc 8.6.10 and Asciidoctor support SOURCE_DATE_EPOCH for > reproducible builds[0], which should reduce the date noise. We could > also add a Makefile knob to set git_version to an empty string or an > --abbrev=0 equivalent for such a situation. > > [0] http

Re: [PATCH] Documentation: fix --color option formatting

2018-07-20 Thread brian m. carlson
On Wed, Jul 18, 2018 at 01:49:44PM -0400, Jeff King wrote: > On Wed, Jul 18, 2018 at 07:37:48PM +0200, Andrei Rybak wrote: > > diff --git a/Documentation/git-for-each-ref.txt > > b/Documentation/git-for-each-ref.txt > > index 085d177d97..901faef1bf 100644 > > --- a/Documentation/git-for-each-ref.t

Re: [PATCH] Documentation: fix --color option formatting

2018-07-18 Thread Junio C Hamano
Andrei Rybak writes: > Add missing colon in two places to fix formatting of options. > > Signed-off-by: Andrei Rybak > --- > > Done on top of maint. > > The earliest this patch applies is on top of commit aebd23506e ("Merge > branch 'jk/ui-color-always-to-auto-maint' into > jk/ui-color-always-to

Re: [PATCH] Documentation: fix --color option formatting

2018-07-18 Thread Jeff King
On Wed, Jul 18, 2018 at 07:37:48PM +0200, Andrei Rybak wrote: > Add missing colon in two places to fix formatting of options. Thanks for catching. > diff --git a/Documentation/git-for-each-ref.txt > b/Documentation/git-for-each-ref.txt > index 085d177d97..901faef1bf 100644 > --- a/Documentation

[PATCH] Documentation: fix --color option formatting

2018-07-18 Thread Andrei Rybak
Add missing colon in two places to fix formatting of options. Signed-off-by: Andrei Rybak --- Done on top of maint. The earliest this patch applies is on top of commit aebd23506e ("Merge branch 'jk/ui-color-always-to-auto-maint' into jk/ui-color-always-to-auto", 2017-10-04), one commit away fro