Thanks a lot for the feedback.
I read Documentation/SubmittingPatches before sending the original patch,
but it seems not everything had sunk in.
(And I definitely should have read it again before sending v2...)
I will resubmit the patch, then.
On Thu, May 12, 2016 at 09:38:59AM -0700, Juni
On Thu, May 12, 2016 at 10:08 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> Seems like Junio was waiting for someone to point this out[2].
>
> Thanks. I think you covered most of them correctly; I only have one
> thing to add.
>
>> * Comments are put after ---. So your paragraph
>>
Pranit Bauva writes:
> Seems like Junio was waiting for someone to point this out[2].
Thanks. I think you covered most of them correctly; I only have one
thing to add.
> * Comments are put after ---. So your paragraph
> "Clarify which commits need to be signed.
>
> Uniformise the
On Thu, May 12, 2016 at 1:34 PM, Pranit Bauva wrote:
> On Thu, May 12, 2016 at 12:20 PM, Fox in the shell
> wrote:
>>
>> Hi,
>>
>> Here is a second attempt at this patch.
>> Sorry for the delay, life somewhat got in the way.
>>
>
> Its okay! We understand that things might take a little more time
On Thu, May 12, 2016 at 12:20 PM, Fox in the shell
wrote:
>
> Hi,
>
> Here is a second attempt at this patch.
> Sorry for the delay, life somewhat got in the way.
>
Its okay! We understand that things might take a little more time than expected!
> --
> Clarify which commits need to be signed.
>
Hi,
Here is a second attempt at this patch.
Sorry for the delay, life somewhat got in the way.
--
Clarify which commits need to be signed.
Uniformise the vocabulary used wrt. key/signature validity with OpenPGP:
- a signature is valid if made by a key with a valid uid;
- in the default trust-mod
6 matches
Mail list logo
