Re: [PATCH] Cygwin has trustable filemode

2013-07-22 Thread Mark Levedahl
On 07/22/2013 01:02 AM, Junio C Hamano wrote: b) The Cygwin project has always shipped git binaries built without NO_TRUSTABLE_FILEMODE That is a fair point. So let's do this instead. -- >8 -- From: Mark Levedahl Subject: [PATCH] cygwin: stop forcing core.filemode=false We force core.filemod

Re: [PATCH] Cygwin has trustable filemode

2013-07-21 Thread Junio C Hamano
Mark Levedahl writes: > On 07/21/2013 05:56 PM, Junio C Hamano wrote: > ... >> There are only three possible ways going forward, I think: >> >> (A) Drop Mark's patch, and do nothing else, because breakages of >> other people's programs are not fixed by Cygwin 1.7's improved >> files

Re: [PATCH] Cygwin has trustable filemode

2013-07-21 Thread Mark Levedahl
On 07/21/2013 05:56 PM, Junio C Hamano wrote: Ramsay Jones writes: Mark Levedahl wrote: The supported Cygwin distribution on supported Windows versions provides complete support for POSIX filemodes, so enable this by default. ... Historical notes: Cygwin version 1.7 supports Windows-XP and ne

Re: [PATCH] Cygwin has trustable filemode

2013-07-21 Thread Junio C Hamano
Ramsay Jones writes: > Mark Levedahl wrote: >> The supported Cygwin distribution on supported Windows versions provides >> complete support for POSIX filemodes, so enable this by default. >> ... >> Historical notes: Cygwin version 1.7 supports Windows-XP and newer, thus >> dropped support for al

Re: [PATCH] Cygwin has trustable filemode

2013-07-21 Thread Ramsay Jones
Mark Levedahl wrote: > The supported Cygwin distribution on supported Windows versions provides > complete support for POSIX filemodes, so enable this by default. git as > distributed by the Cygwin project is configured this way. > > This fixes one testsuite failure: > t3300 test 17 (diff-index -M

Re: [PATCH] Cygwin has trustable filemode

2013-07-20 Thread Ramsay Jones
Mark Levedahl wrote: > On 07/19/2013 12:40 PM, Junio C Hamano wrote: >> Thanks, will replace. >> >> What do we want to do with the compat/regex build-time switch? >> >> IIRC, this was only needed for 1.7 and not 1.5, and I also would >> expect (without anything to back-up, so this is more a faith t

Re: [PATCH] Cygwin has trustable filemode

2013-07-19 Thread Jonathan Nieder
Mark Levedahl wrote: > After merging the following into current pu, all tests that run by > default pass on Cygwin 1.7, i.e. > prove -j 8 t[0-9]*.sh > reports "All tests successful." > I've *never* had this happen on Cygwin before. Nice. Thanks for your hard work. -- To unsubscribe from this

Re: [PATCH] Cygwin has trustable filemode

2013-07-19 Thread Mark Levedahl
On 07/19/2013 03:16 PM, Junio C Hamano wrote: Mark Levedahl writes: Related: Should we have separate settings for 1.5 and 1.7 for several variables? Conflicts I see not reflected in config.mak.uname on pu: trustable filemode (1.7 has, 1.5 does not) MMAP/Pread (1.7 pread is thread s

Re: [PATCH] Cygwin has trustable filemode

2013-07-19 Thread Junio C Hamano
Mark Levedahl writes: > Related: Should we have separate settings for 1.5 and 1.7 for several > variables? Conflicts I see not reflected in config.mak.uname on pu: > trustable filemode (1.7 has, 1.5 does not) > MMAP/Pread (1.7 pread is thread safe, 1.5 I dont think was, MMAP > utility i

Re: [PATCH] Cygwin has trustable filemode

2013-07-19 Thread Mark Levedahl
On 07/19/2013 12:40 PM, Junio C Hamano wrote: Thanks, will replace. What do we want to do with the compat/regex build-time switch? IIRC, this was only needed for 1.7 and not 1.5, and I also would expect (without anything to back-up, so this is more a faith than expectation) over time the "new l

Re: [PATCH] Cygwin has trustable filemode

2013-07-19 Thread Junio C Hamano
Mark Levedahl writes: > Junio - The above notes are more accurate than in my previous commit message, > so if this commit survives into next/master, I would prefer this version as > opposed to the one now on pu (da875762) Thanks, will replace. What do we want to do with the compat/regex build-t

[PATCH] Cygwin has trustable filemode

2013-07-19 Thread Mark Levedahl
The supported Cygwin distribution on supported Windows versions provides complete support for POSIX filemodes, so enable this by default. git as distributed by the Cygwin project is configured this way. This fixes one testsuite failure: t3300 test 17 (diff-index -M -p with mode change quotes funny

Re: [PATCH] Cygwin has trustable filemode

2013-07-16 Thread Mark Levedahl
On 07/16/2013 05:20 PM, Ramsay Jones wrote: Mark Levedahl wrote: The supported Cygwin distribution on supported Windows versions provides complete support for POSIX filemodes, so enable this by default. git as distributed by the Cygwin project is configured this way. This fixes one testsuite fa

Re: [PATCH] Cygwin has trustable filemode

2013-07-16 Thread Ramsay Jones
Mark Levedahl wrote: > The supported Cygwin distribution on supported Windows versions provides > complete support for POSIX filemodes, so enable this by default. git as > distributed by the Cygwin project is configured this way. > > This fixes one testsuite failure: > t3300 test 17 (diff-index -M

[PATCH] Cygwin has trustable filemode

2013-07-14 Thread Mark Levedahl
The supported Cygwin distribution on supported Windows versions provides complete support for POSIX filemodes, so enable this by default. git as distributed by the Cygwin project is configured this way. This fixes one testsuite failure: t3300 test 17 (diff-index -M -p with mode change quotes funny