Re: [PATCH] Correctly close config file handle in case of error

Sven Strickroth writes: > Without this patch there might be open file handle leaks. > > Signed-off-by: Sven Strickroth > Signed-off-by: Sup Yut Sum Who are these two people and how are they related to this change? I am wondering if "Sup" is the author of this change and "Sven" is only relaying

Re: [PATCH] Correctly close config file handle in case of error

On Fri, Aug 14, 2015 at 4:21 PM, Sven Strickroth wrote: > Without this patch there might be open file handle leaks. > > Signed-off-by: Sven Strickroth > Signed-off-by: Sup Yut Sum Better. Thanks. Reviewed-by: Eric Sunshine > --- > diff --git a/config.c b/config.c > index 9fd275f..83caa25 100

[PATCH] Correctly close config file handle in case of error

Without this patch there might be open file handle leaks. Signed-off-by: Sven Strickroth Signed-off-by: Sup Yut Sum --- config.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/config.c b/config.c index 9fd275f..83caa25 100644 --- a/config.c +++ b/config.c @@ -1935,7 +19

Re: [PATCH] Correctly close config file handle in case of error

On Fri, Aug 14, 2015 at 4:03 PM, Sven Strickroth wrote: > Without this patch there might be open file handle leaks. > > Signed-off-by: Sven Strickroth > Signed-off-by: Sup Yut Sum > --- > diff --git a/config.c b/config.c > index 9fd275f..8138d5d 100644 > --- a/config.c > +++ b/config.c > @@ -206

[PATCH] Correctly close config file handle in case of error

Without this patch there might be open file handle leaks. Signed-off-by: Sven Strickroth Signed-off-by: Sup Yut Sum --- config.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config.c b/config.c index 9fd275f..8138d5d 100644 --- a/config.c +++ b/config.c @@ -2065,6 +2065,7 @@ int git_c

Re: [PATCH] Correctly close config file handle in case of error

On Fri, Aug 14, 2015 at 3:44 PM, Sven Strickroth wrote: > Without this patch there might be open file handle leaks. Thanks, this looks better. One comment below... > Signed-off-by: Sven Strickroth > Signed-off-by: Sup Yut Sum > --- > diff --git a/config.c b/config.c > index 9fd275f..c06dc2f 10

[PATCH] Correctly close config file handle in case of error

Without this patch there might be open file handle leaks. Signed-off-by: Sven Strickroth Signed-off-by: Sup Yut Sum --- config.c | 4 1 file changed, 4 insertions(+) diff --git a/config.c b/config.c index 9fd275f..c06dc2f 100644 --- a/config.c +++ b/config.c @@ -2010,6 +2010,7 @@ int git_