Re: [PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-30 Thread Junio C Hamano
Ben Walton writes: > Solaris' tr (both /usr/bin/ and /usr/xpg4/bin) uses the System V > semantics for tr whereby string1's length is truncated to the length > of string2 if string2 is shorter. The BSD semantics, as used by GNU tr > see string2 padded to the length of string1 using the final chara

Re: [PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-28 Thread Ben Walton
Ignore this version. The immediate followup quotes PERL_PATH. On Mon, Oct 28, 2013 at 9:40 PM, Ben Walton wrote: > Solaris' tr (both /usr/bin/ and /usr/xpg4/bin) uses the System V > semantics for tr whereby string1's length is truncated to the length > of string2 if string2 is shorter. The BSD se

[PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-28 Thread Ben Walton
Solaris' tr (both /usr/bin/ and /usr/xpg4/bin) uses the System V semantics for tr whereby string1's length is truncated to the length of string2 if string2 is shorter. The BSD semantics, as used by GNU tr see string2 padded to the length of string1 using the final character in string2. POSIX explic

[PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-28 Thread Ben Walton
Solaris' tr (both /usr/bin/ and /usr/xpg4/bin) uses the System V semantics for tr whereby string1's length is truncated to the length of string2 if string2 is shorter. The BSD semantics, as used by GNU tr see string2 padded to the length of string1 using the final character in string2. POSIX explic

Re: [PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-28 Thread Junio C Hamano
Ben Walton writes: > Per the other discussion about replacing all PERL_PATH with a shell > function named perl, should I update this patch to use $PERL_PATH in > the meantime so that it can be batch updated when the function is > added in a separate patch? Yeah, sounds like a good plan, and very

Re: [PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-28 Thread Ben Walton
On Mon, Oct 28, 2013 at 9:04 PM, Ben Walton wrote: > I'm happy to defer to your judgement on this - If you'd like the tests > wrapped, I'll do so. > > Thanks > -Ben > > On Mon, Oct 28, 2013 at 7:08 PM, Junio C Hamano wrote: >> Jonathan Nieder writes: >> >>> Johannes Sixt wrote: >>> In other

Re: [PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-28 Thread Ben Walton
I'm happy to defer to your judgement on this - If you'd like the tests wrapped, I'll do so. Thanks -Ben On Mon, Oct 28, 2013 at 7:08 PM, Junio C Hamano wrote: > Jonathan Nieder writes: > >> Johannes Sixt wrote: >> >>> In other tests, we check for prerequisite PERL, i.e., we are prepared >>> tha

Re: [PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-28 Thread Junio C Hamano
Jonathan Nieder writes: > Johannes Sixt wrote: > >> In other tests, we check for prerequisite PERL, i.e., we are prepared >> that perl is not available. Shouldn't we do that here, too? > > I think the tests assume there's a perl present even when the PERL > prereq isn't present already. E.g.: >

Re: [PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-28 Thread Jonathan Nieder
Johannes Sixt wrote: > In other tests, we check for prerequisite PERL, i.e., we are prepared > that perl is not available. Shouldn't we do that here, too? I think the tests assume there's a perl present even when the PERL prereq isn't present already. E.g.: nul_to_q () {

Re: [PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-28 Thread Johannes Sixt
Am 28.10.2013 10:13, schrieb Ben Walton: > Solaris' tr (both /usr/bin/ and /usr/xpg4/bin) uses the System V > semantics for tr whereby string1's length is truncated to the length > of string2 if string2 is shorter. The BSD semantics, as used by GNU tr > see string2 padded to the length of string1 u

[PATCH] Avoid difference in tr semantics between System V and BSD

2013-10-28 Thread Ben Walton
Solaris' tr (both /usr/bin/ and /usr/xpg4/bin) uses the System V semantics for tr whereby string1's length is truncated to the length of string2 if string2 is shorter. The BSD semantics, as used by GNU tr see string2 padded to the length of string1 using the final character in string2. POSIX explic