Re: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-14 Thread Felipe Contreras
On Wed, Nov 14, 2012 at 1:11 AM, SZEDER Gábor wrote: > On Tue, Nov 13, 2012 at 07:31:45PM +0100, Felipe Contreras wrote: >> On Mon, Nov 12, 2012 at 9:07 PM, Marc Khouzam wrote: >> > + # Call _git() or _gitk() of the bash script, based on the first >> > + # element of the command-line

Re: Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread Marc Khouzam
On Tue, Nov 13, 2012 at 6:46 PM, SZEDER Gábor wrote: > Hi, > > On Tue, Nov 13, 2012 at 03:12:44PM -0500, Marc Khouzam wrote: >> >> +if [ -n "$1" ] ; then >> >> + # If there is an argument, we know the script is being executed >> >> + # so go ahead and run the _git_complete_with_output function >

Re: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread Marc Khouzam
Thanks for the review. I wasn't aware that you were doing a similar effort for zsh. On Tue, Nov 13, 2012 at 1:31 PM, Felipe Contreras wrote: > On Mon, Nov 12, 2012 at 9:07 PM, Marc Khouzam wrote: > >> this patch allows tcsh-users to get the benefits of the awesome >> git-completion.bash script.

Re: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread SZEDER Gábor
On Tue, Nov 13, 2012 at 07:31:45PM +0100, Felipe Contreras wrote: > On Mon, Nov 12, 2012 at 9:07 PM, Marc Khouzam wrote: > > + # Call _git() or _gitk() of the bash script, based on the first > > + # element of the command-line > > + _${COMP_WORDS[0]} > > You might want to use __

Re: Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread SZEDER Gábor
Hi, I've got two more comments. On Mon, Nov 12, 2012 at 03:07:46PM -0500, Marc Khouzam wrote: > @@ -2481,3 +2483,52 @@ __git_complete gitk __gitk_main > if [ Cygwin = "$(uname -o 2>/dev/null)" ]; then > __git_complete git.exe __git_main > fi > + > +# Method that will output the result of the

Re: Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread SZEDER Gábor
Hi, On Tue, Nov 13, 2012 at 03:12:44PM -0500, Marc Khouzam wrote: > >> +if [ -n "$1" ] ; then > >> + # If there is an argument, we know the script is being executed > >> + # so go ahead and run the _git_complete_with_output function > >> + _git_complete_with_output "$1" "$2" > > > > Where does

Re: Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread Marc Khouzam
Thanks for the review. On Tue, Nov 13, 2012 at 6:14 AM, SZEDER Gábor wrote: > Hi, > > On Mon, Nov 12, 2012 at 03:07:46PM -0500, Marc Khouzam wrote: >> Hi, > > [...] > >> Signed-off-by: Marc Khouzam > > [...] > >> Thanks >> >> Marc >> >> --- >> contrib/completion/git-completion.bash | 53 >> +

Re: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread Felipe Contreras
On Mon, Nov 12, 2012 at 9:07 PM, Marc Khouzam wrote: > this patch allows tcsh-users to get the benefits of the awesome > git-completion.bash script. It could also help other shells do the same. Maybe you can try to take a look at the same for zsh: http://article.gmane.org/gmane.comp.version-con

Re: Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-13 Thread SZEDER Gábor
Hi, On Mon, Nov 12, 2012 at 03:07:46PM -0500, Marc Khouzam wrote: > Hi, [...] > Signed-off-by: Marc Khouzam [...] > Thanks > > Marc > > --- > contrib/completion/git-completion.bash | 53 > +++- > contrib/completion/git-completion.tcsh | 34 +

Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

2012-11-12 Thread Marc Khouzam
Hi, this patch allows tcsh-users to get the benefits of the awesome git-completion.bash script. It could also help other shells do the same. == The current tcsh-completion support for Git, as can be found on the internet, takes the approach of defining the possible completions explicitly. This