Re: [PATCH] Add overflow check to get_delta_hdr_size

2017-08-14 Thread Junio C Hamano
Martin Koegler writes: > From: Martin Koegler > > Signed-off-by: Martin Koegler > --- > Applies on top of my size_t series > > I'm not sure, if die or error is better. As there is no fallback when we hit it, die would be sufficient; the only thing the callers of this helper, or their callers,

Re: [PATCH] Add overflow check to get_delta_hdr_size

2017-08-14 Thread Junio C Hamano
Martin Koegler writes: > From: Martin Koegler > > Signed-off-by: Martin Koegler > --- > Applies on top of my size_t series > > I'm not sure, if die or error is better. As there is no fallback when we hit it, die would be sufficient; the only thing the callers of this helper, or their callers,

[PATCH] Add overflow check to get_delta_hdr_size

2017-08-12 Thread Martin Koegler
From: Martin Koegler Signed-off-by: Martin Koegler --- Applies on top of my size_t series I'm not sure, if die or error is better. delta.h | 5 + 1 file changed, 5 insertions(+) diff --git a/delta.h b/delta.h index 2df0f55..18a4983 100644 --- a/delta.h +++ b/delta.h @@ -96,6 +96,11 @@ st