Re: [PATCH] Add missing test file for UTF-16.

2013-08-06 Thread Junio C Hamano
Duy Nguyen writes: > The intention was "UTF-16 is not supported yet but we want to". But I > don't think we (at least I) will put any effort on that front to allow > NUL in commit message, so the patch, as in "we do not support UTF-16", > is fine. Agreed. Here is what I queued. -- >8 -- Subjec

Re: [PATCH] Add missing test file for UTF-16.

2013-08-06 Thread Duy Nguyen
On Mon, Aug 5, 2013 at 11:44 PM, Junio C Hamano wrote: > Duy Nguyen writes: > >> On Sun, Aug 4, 2013 at 12:26 AM, brian m. carlson >> wrote: >>> The test file that the UTF-16 rejection test looks for is missing, but this >>> went >>> unnoticed because the test is expected to fail anyway; as a c

Re: [PATCH] Add missing test file for UTF-16.

2013-08-05 Thread Junio C Hamano
Duy Nguyen writes: > On Sun, Aug 4, 2013 at 12:26 AM, brian m. carlson > wrote: >> The test file that the UTF-16 rejection test looks for is missing, but this >> went >> unnoticed because the test is expected to fail anyway; as a consequence, the >> test fails because the file containing the co

Re: [PATCH] Add missing test file for UTF-16.

2013-08-04 Thread brian m. carlson
On Sun, Aug 04, 2013 at 09:31:01AM +0700, Duy Nguyen wrote: > Tested-by: Duy Nguyen I think you're missing an "l" in the domain name there. > and sorry, my bad. I think we need your sign-off in this patch. I just ran across it because I'm going through all the TODO tests and seeing which ones I

Re: [PATCH] Add missing test file for UTF-16.

2013-08-03 Thread Duy Nguyen
On Sun, Aug 4, 2013 at 12:26 AM, brian m. carlson wrote: > The test file that the UTF-16 rejection test looks for is missing, but this > went > unnoticed because the test is expected to fail anyway; as a consequence, the > test fails because the file containing the commit message is missing, and

[PATCH] Add missing test file for UTF-16.

2013-08-03 Thread brian m. carlson
The test file that the UTF-16 rejection test looks for is missing, but this went unnoticed because the test is expected to fail anyway; as a consequence, the test fails because the file containing the commit message is missing, and not because the test file contains a NUL byte. Fix this by includi