Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-22 Thread Junio C Hamano
Job Snijders writes: > For people that work with very large plain text files it may be easier > if one can bypass viewing the htmlized blob and instead click directly > to the raw file (rather then click through 'blob' and then to 'raw'). > > Reviewed-by: Giuseppe Bilotta > Signed-off-by: Job Sn

Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-22 Thread Job Snijders
For people that work with very large plain text files it may be easier if one can bypass viewing the htmlized blob and instead click directly to the raw file (rather then click through 'blob' and then to 'raw'). Reviewed-by: Giuseppe Bilotta Signed-off-by: Job Snijders --- gitweb/gitweb.perl |

Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-22 Thread Junio C Hamano
Job Snijders writes: > On Tue, Aug 22, 2017 at 12:22:43PM -0700, Junio C Hamano wrote: >> Job Snijders writes: >> > Add 'raw' blob_plain link in history overview >> > >> > Reviewed-by: Giuseppe Bilotta >> > Signed-off-by: Job Snijders >> > >> > --- >> >> Thanks; I somehow thought that your ea

Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-22 Thread Giuseppe Bilotta
On Tue, Aug 22, 2017 at 9:35 PM, Job Snijders wrote: > We often work with very large plain text files in our repositories and > found it friendlier to the users if we can click directly to the raw > version of such files. It might be worth it to add this information to the commit message. -- G

Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-22 Thread Job Snijders
On Tue, Aug 22, 2017 at 12:22:43PM -0700, Junio C Hamano wrote: > Job Snijders writes: > > Add 'raw' blob_plain link in history overview > > > > Reviewed-by: Giuseppe Bilotta > > Signed-off-by: Job Snijders > > > > --- > > Thanks; I somehow thought that your earlier one not just said what > it

Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-22 Thread Junio C Hamano
Job Snijders writes: > Add 'raw' blob_plain link in history overview > > Reviewed-by: Giuseppe Bilotta > Signed-off-by: Job Snijders > > --- Thanks; I somehow thought that your earlier one not just said what it does (twice---that is not needed) but why this change is useful, but that is lost i

Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-21 Thread Job Snijders
Add 'raw' blob_plain link in history overview Reviewed-by: Giuseppe Bilotta Signed-off-by: Job Snijders --- gitweb/gitweb.perl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 9208f42ed..959f04b49 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/

Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-21 Thread Giuseppe Bilotta
Hello, On Mon, Aug 21, 2017 at 12:44 PM, Job Snijders wrote: > On Mon, Aug 21, 2017 at 12:19:38PM +0200, Giuseppe Bilotta wrote: > Thank you for your feedback, good point. Please see below: This looks fine > --- > > Add a 'raw' blob_plain link in history overview > > Signed-off-by: Job Snijders

Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-21 Thread Job Snijders
On Mon, Aug 21, 2017 at 12:19:38PM +0200, Giuseppe Bilotta wrote: > >> This patch adds a 'raw' blob_plain link in history overview. > > Arguably, the addition of the 'raw' link should be done in the same > conditional that also adds the 'diff to current' link, before the diff > to current link. >

Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-21 Thread Giuseppe Bilotta
Hello, On Sun, Aug 20, 2017 at 8:03 PM, Job Snijders wrote: > bump? (As a side note, I have also noticed that gitweb patches tend to go unreviewed for long) > On Wed, Aug 02, 2017 at 08:59:01PM +0200, Job Snijders wrote: >> We often work with very large plain text files in our repositories and

Re: [PATCH] Add 'raw' blob_plain link in history overview

2017-08-20 Thread Job Snijders
bump? On Wed, Aug 02, 2017 at 08:59:01PM +0200, Job Snijders wrote: > We often work with very large plain text files in our repositories and > found it friendlier to the users if we can click directly to the raw > version of such files. > > This patch adds a 'raw' blob_plain link in history over

[PATCH] Add 'raw' blob_plain link in history overview

2017-08-02 Thread Job Snijders
We often work with very large plain text files in our repositories and found it friendlier to the users if we can click directly to the raw version of such files. This patch adds a 'raw' blob_plain link in history overview. Signed-off-by: Job Snijders --- gitweb/gitweb.perl | 7 +-- 1 file