Re: [PATCH] [submodule] Remove duplicate call to set_rev_name

Heiko Voigt writes: > Hi, > > On Mon, Jun 17, 2013 at 11:55:36AM +0200, Fredrik Gustafsson wrote: >> set_rev_name is a possible expensive operation. If a submodule has >> changes in it, set_rev_name was called twice. >> >> Solution is to move set_rev_name so it's only called once, no matter the

Re: [PATCH] [submodule] Remove duplicate call to set_rev_name

Hi, On Mon, Jun 17, 2013 at 11:55:36AM +0200, Fredrik Gustafsson wrote: > set_rev_name is a possible expensive operation. If a submodule has > changes in it, set_rev_name was called twice. > > Solution is to move set_rev_name so it's only called once, no matter the > codepath taken. Looks good t

[PATCH] [submodule] Remove duplicate call to set_rev_name

set_rev_name is a possible expensive operation. If a submodule has changes in it, set_rev_name was called twice. Solution is to move set_rev_name so it's only called once, no matter the codepath taken. Signed-off-by: Fredrik Gustafsson --- git-submodule.sh | 4 ++-- 1 file changed, 2 insertions