Re: [PATCH] [GSoC] remove_subtree(): reimplement using iterators

2017-03-24 Thread Daniel Ferreira (theiostream)
> On Fri, Mar 24, 2017 at 2:02 PM, Stefan Beller wrote: > Welcome to the Git community! Thank you! > Please use a more imperative style. (e.g. s/Uses/Use/ ... > s/and simplfying/which simplifies/) Thank you. Will do in a second version of this patch. > Thanks for this link. It gives good cont

Re: [PATCH] [GSoC] remove_subtree(): reimplement using iterators

2017-03-24 Thread Stefan Beller
Welcome to the Git community! On Thu, Mar 23, 2017 at 9:07 PM, Daniel Ferreira wrote: > Uses dir_iterator to traverse through remove_subtree()'s directory tree, > avoiding the need for recursive calls to readdir() and simplifying code. Please use a more imperative style. (e.g. s/Uses/Use/ ... s/

[PATCH] [GSoC] remove_subtree(): reimplement using iterators

2017-03-23 Thread Daniel Ferreira
Uses dir_iterator to traverse through remove_subtree()'s directory tree, avoiding the need for recursive calls to readdir() and simplifying code. Suggested in the GSoC microproject list, as well as: https://public-inbox.org/git/xmqqk27m4h3h@gitster.mtv.corp.google.com/ A conversion similar in