Re: [PATCH][RFC] read-cache: read_index_from() accepts repo as arg

2019-04-08 Thread Taylor Blau
Hi Kapil, On Sun, Apr 07, 2019 at 01:07:12PM +0530, Kapil Jain wrote: > Signed-off-by: Kapil Jain > --- > > In read-cache, the read_index_from() function had a TODO task, > this patch completes that. There are some other functions in the same file > where this exact TODO needs to be done, will pr

Re: [PATCH][RFC] read-cache: read_index_from() accepts repo as arg

2019-04-07 Thread Duy Nguyen
On Sun, Apr 07, 2019 at 05:00:11PM +0700, Duy Nguyen wrote: > So, with something like a patch below (not tested), you should be able > to write > > worktrees = repo_get_worktrees(revs->repo, 0); > ... > struct repository *r = repo_worktree_init(wt); > if (re

Re: [PATCH][RFC] read-cache: read_index_from() accepts repo as arg

2019-04-07 Thread Duy Nguyen
On Sun, Apr 07, 2019 at 01:07:12PM +0530, Kapil Jain wrote: > Signed-off-by: Kapil Jain > --- > > In read-cache, the read_index_from() function had a TODO task, this > patch completes that. This line at least should be above the "---" line (i.e. part of the commit message). > diff --git a/read-

[PATCH][RFC] read-cache: read_index_from() accepts repo as arg

2019-04-07 Thread Kapil Jain
Signed-off-by: Kapil Jain --- In read-cache, the read_index_from() function had a TODO task, this patch completes that. There are some other functions in the same file where this exact TODO needs to be done, will proceed to do them once this patch is accepted. running test gave 256 not okays, e