Re: [PATCH/RFC v3 3/3] branch: add copy branch feature implementation

2017-06-01 Thread Sahil Dua
On Thu, Jun 1, 2017 at 8:59 PM, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Jun 1, 2017 at 8:35 PM, Sahil Dua wrote: > > Adds copy branch option available using -c or -C (forcefully). > > Commenting on the series in general. I have a fixup branch for you > with commits to squash: > https://github.

Re: [PATCH/RFC v3 3/3] branch: add copy branch feature implementation

2017-06-01 Thread Ævar Arnfjörð Bjarmason
On Thu, Jun 1, 2017 at 8:35 PM, Sahil Dua wrote: > Adds copy branch option available using -c or -C (forcefully). Commenting on the series in general. I have a fixup branch for you with commits to squash: https://github.com/avar/git/tree/avar/sahildua-rename-branch-2 issues: - There's a mixed v

[PATCH/RFC v3 3/3] branch: add copy branch feature implementation

2017-06-01 Thread Sahil Dua
Adds copy branch option available using -c or -C (forcefully). Adds new function copy_existing_ref to copy the ref and git_config_copy_section to copy the git config section. Under the hood, both git_config_copy_section and git_config_rename_section functions use the same function which takes a fl