Re: [PATCH/RFC v3 06/13] Read index-v5

2012-08-08 Thread Thomas Gummerer
On 08/08, Nguyen Thai Ngoc Duy wrote: > uOn Wed, Aug 8, 2012 at 6:17 PM, Thomas Gummerer wrote: > > +static struct cache_entry *read_entry(struct directory_entry *de, > > + unsigned long *entry_offset, > > + void **mmap, > > + unsig

Re: [PATCH/RFC v3 06/13] Read index-v5

2012-08-08 Thread Junio C Hamano
Nguyen Thai Ngoc Duy writes: >> +struct index_ops v5_ops = { >> + match_stat_basic, >> + verify_hdr, >> + read_index_v5, >> + NULL >> +}; > > If you do it right, putting write_index_v2 here should work because > in-core structure is not changed (except that write_index_v2

Re: [PATCH/RFC v3 06/13] Read index-v5

2012-08-08 Thread Johannes Sixt
Am 8/8/2012 14:05, schrieb Nguyen Thai Ngoc Duy: > uOn Wed, Aug 8, 2012 at 6:17 PM, Thomas Gummerer wrote: >> +static struct cache_entry *read_entry(struct directory_entry *de, >> + unsigned long *entry_offset, >> + void **mmap, >> +

Re: [PATCH/RFC v3 06/13] Read index-v5

2012-08-08 Thread Nguyen Thai Ngoc Duy
uOn Wed, Aug 8, 2012 at 6:17 PM, Thomas Gummerer wrote: > +static struct cache_entry *read_entry(struct directory_entry *de, > + unsigned long *entry_offset, > + void **mmap, > + unsigned long mmap_size, > + un

[PATCH/RFC v3 06/13] Read index-v5

2012-08-08 Thread Thomas Gummerer
Make git read the index file version 5 without complaining. This version of the reader doesn't read neither the cache-tree nor the resolve undo data, but doesn't choke on an index that includes such data. Helped-by: Nguyen Thai Ngoc Duy Helped-by: Thomas Rast Signed-off-by: Thomas Gummerer ---