Re: [PATCH/RFC v3] add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
I figured it out, It first runs status_init_config(). I might have thought "status" as status of the options and thus I may have edited there. On Fri, Mar 11, 2016 at 3:08 AM, Pranit Bauva wrote: > On Fri, Mar 11, 2016 at 3:04 AM, Junio C Hamano > wrote: >> But doesn't this belong to git_commit_

Re: [PATCH/RFC v3] add a commit.verbose config variable

2016-03-10 Thread Junio C Hamano
Pranit Bauva writes: > On Fri, Mar 11, 2016 at 3:04 AM, Junio C Hamano > wrote: >> But doesn't this belong to git_commit_config(), not >> git_STATUS_config()? Should "commit.verbose" make output from "git >> status" verbose? > > True. It should belong to git_commit_config(). My bad. But > surpr

Re: [PATCH/RFC v3] add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
On Fri, Mar 11, 2016 at 3:04 AM, Junio C Hamano wrote: > But doesn't this belong to git_commit_config(), not > git_STATUS_config()? Should "commit.verbose" make output from "git > status" verbose? True. It should belong to git_commit_config(). My bad. But surprisingly this code works. I have no

Re: [PATCH/RFC v3] add a commit.verbose config variable

2016-03-10 Thread Junio C Hamano
Pranit Bauva writes: > diff --git a/builtin/commit.c b/builtin/commit.c > index b3bd2d4..63ee0f2 100644 > --- a/builtin/commit.c > +++ b/builtin/commit.c > @@ -1310,6 +1310,10 @@ static int git_status_config(const char *k, const char > *v, void *cb) > return error(_("Invali

Re: [PATCH/RFC v3] add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
Older versions of this patch can be found at :- [v2] : http://thread.gmane.org/gmane.comp.version-control.git/288569 [v1] : http://thread.gmane.org/gmane.comp.version-control.git/287540 The changes are : - Remove the concept of override-verbose - Add the git_config_bool to the method git_status_

[PATCH/RFC v3] add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
Since many people always run the command with this option, it would be preferrable to specify it in the configuration file instead of passing the option with `git commit` again and again. Signed-off-by: Pranit Bauva --- Documentation/config.txt | 4 Documentation/git-commit.txt | 3 ++-