Re: [PATCH/RFC 4/5] mingw: reuse tty-version of git_terminal_prompt

2012-11-30 Thread Jeff King
On Tue, Nov 13, 2012 at 03:04:06PM +0100, Erik Faye-Lund wrote: > The getpass-implementation we use on Windows isn't at all ideal; > it works in raw-mode (as opposed to cooked mode), and as a result > does not deal correcly with deletion, arrow-keys etc. > > Instead, use cooked mode to read a lin

Re: [msysGit] [PATCH/RFC 4/5] mingw: reuse tty-version of git_terminal_prompt

2012-11-30 Thread Johannes Schindelin
Hi kusma, On Tue, 13 Nov 2012, Erik Faye-Lund wrote: > The getpass-implementation we use on Windows isn't at all ideal; > it works in raw-mode (as opposed to cooked mode), and as a result > does not deal correcly with deletion, arrow-keys etc. > > Instead, use cooked mode to read a line at the t

[PATCH/RFC 4/5] mingw: reuse tty-version of git_terminal_prompt

2012-11-13 Thread Erik Faye-Lund
The getpass-implementation we use on Windows isn't at all ideal; it works in raw-mode (as opposed to cooked mode), and as a result does not deal correcly with deletion, arrow-keys etc. Instead, use cooked mode to read a line at the time, allowing the C run-time to process the input properly. Sinc